Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update devcontainer base to 23.10 #1116

Merged

Conversation

cwharris
Copy link
Contributor

@cwharris cwharris commented Aug 2, 2023

Update the devcontainer base to 23.10 (this has no relation to cudf versioning).

While there are other improvements, the main reason I'm upgrading is due to a newer version of git, which allows inline public key signing of commits - something we need to be able to commit changes while inside the container without having to manage separate container-specific signing keys.

Example of signing key usage (from host, inherited by devcontainer):

ssh-keygen -t ed25519 -C "example@nvidia.com"
git config --global user.signingkey "key::$(cat ~/.ssh/id_ed25519.pub)"
git config --global commit.gpgsign true
git config --global gpg.format ssh
mkdir -p ~/.config/git
git config --global gpg.ssh.allowedSignersFile ~/.config/git/allowed_signers
awk 'BEGIN {FS=" "; OFS=" "} {print $3, $1, $2}' <(ssh-add -L) > ~/.config/git/allowed_signers

@cwharris cwharris added non-breaking Non-breaking change improvement Improvement to existing functionality labels Aug 2, 2023
@cwharris cwharris requested a review from a team as a code owner August 2, 2023 23:13
@cwharris
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 5af1cdb into nv-morpheus:branch-23.11 Aug 22, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement to existing functionality non-breaking Non-breaking change
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants