Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove multiprocess download option #1189

Merged

Conversation

efajardo-nv
Copy link
Contributor

Description

  • Remove multiprocess download option
  • Update unit tests and docs

Closes #1145

By Submitting this PR I confirm:

  • I am familiar with the Contributing Guidelines.
  • When the PR is ready for review, new or existing tests cover these changes.
  • When the PR is ready for review, the documentation is up to date with these changes.

@efajardo-nv efajardo-nv added bug Something isn't working non-breaking Non-breaking change labels Sep 12, 2023
@efajardo-nv efajardo-nv self-assigned this Sep 12, 2023
@efajardo-nv efajardo-nv marked this pull request as ready for review September 13, 2023 14:55
@efajardo-nv efajardo-nv requested a review from a team as a code owner September 13, 2023 14:55
Copy link
Contributor

@mdemoret-nv mdemoret-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing a deprecation warning and tests for that warning as outlined on the issue here.

@mdemoret-nv mdemoret-nv added breaking Breaking change and removed non-breaking Non-breaking change labels Sep 13, 2023
Copy link
Contributor

@mdemoret-nv mdemoret-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the test

@efajardo-nv
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit f68ba33 into nv-morpheus:branch-23.11 Sep 25, 2023
4 checks passed
@efajardo-nv efajardo-nv deleted the remove-multiprocess-download branch July 29, 2024 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Breaking change bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[BUG]: Error with Azure DFP examples when using multiprocess download method
2 participants