Fixes Timestamp Nodes When Running with --debug
#145
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the user runs with
--debug
, then any stage that derives fromMultiMessageStage
, will insert columns with the message timestamp for when it was finished processing. With some of the recent changes to Neo, we disabled broadcast nodes. However, the timestamp code didnt get updated.This PR fixes a few things:
None
supports_cpp_node
_build_cpp_node()
returns the correct thing_build_cpp_node()
to determine whether C++ is being used for this particular stage_build_cpp_node()
instead ofCppConfig.get_should_use_cpp()
Fixes #143