Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix or silence warnings emitted during tests #1457

Closed
wants to merge 51 commits into from
Closed

Fix or silence warnings emitted during tests #1457

wants to merge 51 commits into from

Conversation

dagardner-nv
Copy link
Contributor

@dagardner-nv dagardner-nv commented Jan 8, 2024 •
edited
Loading

Description

  • Reduces the number of warnings from running all tests from 2194 down to 2
  • Ensure we receive a cuda build of pyarrow
  • Install pyarrow_hotfix via conda rather than pip
  • Sort channel priorities to ensure the nvidia and rapidsai version of a package is preferred
  • Adopt dgl v1.1.1 which adds pytorch 2.01 support
  • Add missing dep for ccache
  • Pin numpy and pandas to compat with our cudf
  • Add pip transitive deps ensuring the conda version of packages is installed rather than the pip package.
  • Replace usage of deprecated methods/attribues
  • When no other option is avail, silence known warnings.

By Submitting this PR I confirm:

  • I am familiar with the Contributing Guidelines.
  • When the PR is ready for review, new or existing tests cover these changes.
  • When the PR is ready for review, the documentation is up to date with these changes.

@dagardner-nv
Ignore deprecation warnings from gputil
598a1db
@dagardner-nv
Suppress warnings from merlin/nvt regardning tensorflow not being ins…
0dc1816 
…talled
@dagardner-nv
Revert "Ignore deprecation warnings from gputil"
80575ca 
This reverts commit 598a1db.
@dagardner-nv
Ignore distutils deprecation warning
7a722bb
@dagardner-nv
Mark the http server tests as slow
0d1fa37
@dagardner-nv
Capture the warning emitted when timestamp is provided but timestamp …
da692e8 
…pattern is not
@dagardner-nv
Narrow the warning filters to be more specific, ensuring we aren't ac…
f1dcd44 
…cidentally ignoring other warnings
@dagardner-nv
Merge branch 'branch-24.03' of github.com:nv-morpheus/Morpheus into d…
374d6d6 
…avid-pytest-warnings
@dagardner-nv
Silence warnings about not having a config option
42614ec
@dagardner-nv
Avoid warning from cudf regardning an upcoming change of behavior whe…
074081e 
…n applying a groupby to a list with only a single element refer: https://github.com/rapidsai/cudf/blob/branch-24.02/python/cudf/cudf/core/groupby/groupby.py#L281
@dagardner-nv
Add comment explaining the special handling of single element lists
3a822c7
@dagardner-nv
WIP: need to find the root cause of this warning
3282475
@dagardner-nv
Update CR Year
a226c17
@dagardner-nv
Merge branch 'david-pytest-warnings' into david-pytest-warnings-p2
907f7d7
@dagardner-nv
Add comment explaining the warning coming from numpy 1.26
a0bbee2
@dagardner-nv
Merge branch 'branch-24.03' of github.com:nv-morpheus/Morpheus into d…
62915f5 
…avid-pytest-warnings-p2
@dagardner-nv dagardner-nv added non-breaking Non-breaking change improvement Improvement to existing functionality DO NOT MERGE PR should not be merged; see PR for details skip-ci Optionally Skip CI for this PR labels Jan 8, 2024
@dagardner-nv dagardner-nv self-assigned this Jan 8, 2024
@dagardner-nv dagardner-nv requested a review from a team as a code owner January 8, 2024 18:01
@dagardner-nv dagardner-nv marked this pull request as draft January 8, 2024 18:01
@dagardner-nv
Update test for completion pipe to use actual asyncio futures, simila…
592f7f4 
…r to that used by the completion benchmark, this removes the need to mock the asyncio.gather method which is also used by the PromptTemplateNode
@dagardner-nv
Avoid warning about setting values on a copy
032ddec
@dagardner-nv
Ignore performance warnings from pandas triggered by the df compare m…
766d474 
…ethod in the tests
@dagardner-nv
Restrict numpy to versions prior to 1.25, this avoids numerous warnin…
5462726 
…gs triggered by cudf, more recent versions of cudf use this same version restriction
@dagardner-nv
Silence warning about cudf's subword tokenizer behaving differently t…
874776f 
…han huggingface
@dagardner-nv
Avoid pandas warning about setting a value on a copy
21d8562
@dagardner-nv
Ignore the warning from the logging_timer which happens whenever DFPS…
03168a2 
…plitUsersStage doesn't have any output messages
@dagardner-nv dagardner-nv removed DO NOT MERGE PR should not be merged; see PR for details skip-ci Optionally Skip CI for this PR labels Jan 12, 2024
@dagardner-nv dagardner-nv changed the title Silence warnings Fix or silence warnings generated by Morpheus Jan 12, 2024
@dagardner-nv dagardner-nv changed the title Fix or silence warnings generated by Morpheus Fix or silence warnings emitted during tests Jan 12, 2024
@dagardner-nv
Ensure we receive a cuda enabled build of pyarrow
e07b1c6 
re-order channels ensuring nvidia & rapidsai versions of packages receive priority
Add missing dep for ccache
Pin pandas to 1.3, more recent versions trigger deprecation warnins from cudf
Add in pip transitive deps, ensuring we receive the conda versions rather than the pip versions
@dagardner-nv
update CR
82ca88b
@dagardner-nv
lint fixes
95748a4
@dagardner-nv
formatting
02c74fb
@dagardner-nv
lint fixes
1347cb3
@dagardner-nv
Fix fixture names
6891868
@dagardner-nv dagardner-nv marked this pull request as ready for review January 12, 2024 20:39
@dagardner-nv dagardner-nv requested a review from a team as a code owner January 12, 2024 20:39
mdemoret-nv
mdemoret-nv requested changes Jan 17, 2024
View reviewed changes
Copy link
Contributor

@mdemoret-nv mdemoret-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes to the warnings look good. Lets wait for PR #1468 to be merged first before we make any changes to the dependencies.yaml

tests/test_column_info.py Outdated Show resolved Hide resolved
tests/test_column_info.py Outdated Show resolved Hide resolved
@dagardner-nv dagardner-nv added the DO NOT MERGE PR should not be merged; see PR for details label Jan 17, 2024
@dagardner-nv
Copy link
Contributor Author

Closing in favor of PR #1501

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdemoret-nv mdemoret-nv mdemoret-nv requested changes

Assignees

@dagardner-nv dagardner-nv

Labels
DO NOT MERGE PR should not be merged; see PR for details improvement Improvement to existing functionality non-breaking Non-breaking change
Projects
Morpheus Boards
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dagardner-nv @mdemoret-nv