-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add file handler to capture langchain agent logging #1515
Closed
dagardner-nv
wants to merge
13
commits into
nv-morpheus:branch-24.06
from
dagardner-nv:david-langchain-agent-logging
Closed
Add file handler to capture langchain agent logging #1515
dagardner-nv
wants to merge
13
commits into
nv-morpheus:branch-24.06
from
dagardner-nv:david-langchain-agent-logging
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…avid-langchain-agent-logging
…avid-langchain-agent-logging
fix paths to yaml files
…sn't pretent to have attributes that the original does not have
dagardner-nv
added
non-breaking
Non-breaking change
feature request
New feature or request
sherlock
Issues/PRs related to Sherlock workflows and components
labels
Feb 13, 2024
efajardo-nv
reviewed
Feb 13, 2024
Comment on lines
+143
to
+145
llm_agent_file_handler = _get_file_handler(llm_agent_log_file) | ||
llm_agent_file_handler.addFilter(logging.Filter(name=LLM_AGENT_LOG_NAME)) | ||
llm_agent_logger.addHandler(llm_agent_file_handler) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fyi - This PR updates logger so that you can pass in additional handlers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
feature request
New feature or request
non-breaking
Non-breaking change
sherlock
Issues/PRs related to Sherlock workflows and components
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
agent.log
in the user's log dir.astream
method (https://python.langchain.com/docs/modules/agents/how_to/streaming#using-agentactionobservation) which is available in langchain 0.0.310, but not in 0.0.190AgentExecutor
instance contains anastream
attribute it is used allowing us to log intermediate steps, otherwise the olderarun
method is used.Note: this feature requires langchain 0.0.310 which requires pandas 2.0
By Submitting this PR I confirm: