Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix memory leak in the mutable dataframe checkout/checkin code #1534

Merged
merged 4 commits into from
Feb 26, 2024
Merged

Fix memory leak in the mutable dataframe checkout/checkin code #1534

merged 4 commits into from
Feb 26, 2024

Conversation

dagardner-nv
Copy link
Contributor

Description

  • Switch to using a unique_ptr to hold the python object
  • Random IWYU fixes.

Closes #1533

By Submitting this PR I confirm:

  • I am familiar with the Contributing Guidelines.
  • When the PR is ready for review, new or existing tests cover these changes.
  • When the PR is ready for review, the documentation is up to date with these changes.

@dagardner-nv dagardner-nv requested a review from a team as a code owner February 26, 2024 18:51
@dagardner-nv dagardner-nv self-assigned this Feb 26, 2024
@dagardner-nv dagardner-nv added bug Something isn't working non-breaking Non-breaking change labels Feb 26, 2024
@dagardner-nv
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit eeb8b51 into nv-morpheus:branch-24.03 Feb 26, 2024
10 checks passed
@dagardner-nv dagardner-nv deleted the david-mutable-df-leak branch February 26, 2024 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drobison00 drobison00 drobison00 approved these changes

Assignees

@dagardner-nv dagardner-nv

Labels
bug Something isn't working non-breaking Non-breaking change
Projects
Morpheus Boards
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG]: GPU Memory Leak when using MessageMeta mutable_dataframe()
2 participants
@dagardner-nv @drobison00