Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support non-json serializable objects in LLMContext #1581

Closed
wants to merge 19 commits into from
Closed

Support non-json serializable objects in LLMContext #1581

wants to merge 19 commits into from

Conversation

dagardner-nv
Copy link
Contributor

@dagardner-nv dagardner-nv commented Mar 25, 2024 •
edited
Loading

Description

Closes #1560

By Submitting this PR I confirm:

  • I am familiar with the Contributing Guidelines.
  • When the PR is ready for review, new or existing tests cover these changes.
  • When the PR is ready for review, the documentation is up to date with these changes.

@dagardner-nv
Revert to returning the exception rather than an error string
46bd47e
@dagardner-nv
WIP
bb3fa5c
@dagardner-nv
Update testt, inside of LLMContext::pop() are three if/else branches,…
e2db600 
… when the context has no output names or only one output name, then the values are std::moved, otherwise the values are copied I think this is a bug, I fixed it and updated the test to match
@dagardner-nv
Add new overrides for set_output
63112e1
@dagardner-nv dagardner-nv added bug Something isn't working non-breaking Non-breaking change DO NOT MERGE PR should not be merged; see PR for details skip-ci Optionally Skip CI for this PR labels Mar 25, 2024
@dagardner-nv dagardner-nv self-assigned this Mar 25, 2024
@dagardner-nv dagardner-nv requested a review from a team as a code owner March 25, 2024 14:31
@dagardner-nv dagardner-nv marked this pull request as draft March 25, 2024 14:31
@mdemoret-nv mdemoret-nv changed the base branch from branch-24.03 to branch-24.06 March 27, 2024 19:55
@dagardner-nv
Copy link
Contributor Author

closing in favor of PR #1589

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@dagardner-nv dagardner-nv

Labels
bug Something isn't working DO NOT MERGE PR should not be merged; see PR for details non-breaking Non-breaking change skip-ci Optionally Skip CI for this PR
Projects
Morpheus Boards
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEA]: Update LLMContext to store outputs that are not json serializable
1 participant
@dagardner-nv