-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update examples to execute from the root of the repo #1674
Merged
rapids-bot
merged 38 commits into
nv-morpheus:branch-24.06
from
dagardner-nv:examples-in-root-1671
May 2, 2024
Merged
Update examples to execute from the root of the repo #1674
rapids-bot
merged 38 commits into
nv-morpheus:branch-24.06
from
dagardner-nv:examples-in-root-1671
May 2, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed_memory is true
…e grpc port since we're using the python impl now
…t causes a float32 vs float64 error in the add-scores stage
2 tasks
…ays enabled for C++ mode
…ays enabled for C++ mode
efajardo-nv
approved these changes
May 1, 2024
efajardo-nv
reviewed
May 1, 2024
mdemoret-nv
approved these changes
May 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of removing the --force_convert_inputs
lets pass the variable down and check if its needed. If they dont match, either throw an exception or pass to triton unchanged. Follow the python implementation.
…xamples-in-root-1671 [no ci]
TODO: Need to ensure that we don't go into the retry logic on a thrown exception due to a type-mismatch
…it from connection errors which should be retried
…which errors prior to succeeding and FakeTritonClient which returns mocked results
…xamples-in-root-1671
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
MORPHEUS_ROOT
force_convert_inputs=true
and the input and model types didn't match (previously types were always casted)--num_threads=1
restriction and configure logging for thelog_parsing
example--num_threads=8
restriction fromnlp_si_detection
since the pipeline has more than 8 stages.use_shared_memory
is requested as this isn't supported in C++.gnn-fraud-classification
stage to CLI alternative forgnn_fraud_detection_pipeline
exampleCloses #1671
By Submitting this PR I confirm: