Merge Agent Morpheus changes #1760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…url parameters to existing services for config parity.
## Description Adds the ability to instantiate LLM services/clients dynamically, so that models can be swapped out with command line arguments or config files instead of having to refactor pipeline code. Closes #1630 ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/nv-morpheus/Morpheus/blob/main/docs/source/developer_guide/contributing.md). - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes.
…h `langchain-nvidia-ai-endpoints` library
…#1679) ## Description This PR standardizes the `NVIDIA_API_BASE` environment variable to `NVAI_BASE_URL` per discussion with maintainers. The new name better reflects the usage of this API for LLM-related tasks, and disambiguates it from other NVIDIA APIs we may need to use in the future. I also updated the `NVFoundationLLMService` docstring with the new default base url used in the `langchain-nvidia-ai-endpoints` library. ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/nv-morpheus/Morpheus/blob/main/docs/source/developer_guide/contributing.md). - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes.
…orpheus into openai-client-updates
…agent-parsing-error-handling
…gent-morpheus-tests
…agent-parsing-error-handling
|
/ok to test |
yczhang-nv
reviewed
Jun 24, 2024
…r the WriteToFileController since this already had the overwrite logic, also fixes a problem when the output file is a relative path without a directory prefix
|
/ok to test |
dagardner-nv
commented
Jun 25, 2024
dagardner-nv
added
breaking
…erator comprehension rather than a list comprehension
|
/ok to test |
mdemoret-nv
approved these changes
Jun 25, 2024
|
/ok to test |
|
/ok to test |
|
/ok to test |
|
/ok to test |
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fea-agent-morpheusfeature branch into 24.06By Submitting this PR I confirm: