Removing support for MultiMessage from stages
#1803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yczhang-nv
added
breaking
|
/ok to test |
|
/ok to test |
|
/ok to test |
|
/ok to test |
|
/ok to test |
|
/ok to test |
mdemoret-nv
approved these changes
Sep 10, 2024
|
/ok to test |
dagardner-nv
approved these changes
Sep 10, 2024
python/morpheus/morpheus/_lib/include/morpheus/stages/add_scores_stage_base.hpp
Show resolved
Hide resolved
mdemoret-nv
approved these changes
Sep 10, 2024
|
/ok to test |
|
/ok to test |
|
/merge |
rapids-bot bot
pushed a commit
that referenced
this pull request
Sep 12, 2024
Should be merged after merging #1803. The Final step of completely remove `MultiMessage` from the whole Morpheus repo. This PR removes `MultiMessage` and its sub-classes. All occurrences of `MultiMessage` and its sub-classes in examples and docs are updated to `ControlMessage`. Closes #1802 ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/nv-morpheus/Morpheus/blob/main/docs/source/developer_guide/contributing.md). - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. Authors: - Yuchen Zhang (https://github.com/yczhang-nv) - Michael Demoret (https://github.com/mdemoret-nv) Approvers: - David Gardner (https://github.com/dagardner-nv) - Michael Demoret (https://github.com/mdemoret-nv) URL: #1886
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Part of finalizing
MultiMessagedeprecation. Previously the stages support processing bothControlMessageandMultiMessage- this PR removes the code paths forMultiMessagefrom the following stages (from both C++ & Python implementation):Pre-process stages:
deserialize_stagepreprocess_base_stagepreprocess_ae_stagepreprocess_fil_stagepreprocess_nlp_stagetrain_ae_stagePost-process stages:
serialize_stageadd_scores_stage_base_stageadd_scores_stageadd_classification_stagefilter_detections_stagegenerate_viz_frames_stageml_flow_drift_stagetime_series_stagevalidation_stageInference stages:
auto_encoder_inference_stageidentity_inference_stageinference_stagepytorch_inference_stagetriton_inference_stageOutput stages:
write_to_vector_db_stageThe related unit tests are also updated to use only
ControlMessage.Morpheus examples that imports stages/messages directly (rather than creating their own version) are also updated to get CI passed for this PR.
Closes #1887
By Submitting this PR I confirm: