Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix log parsing undefined variable and duplicate sequence id errors #1809

Merged
merged 12 commits into from
Jul 25, 2024
Merged

Fix log parsing undefined variable and duplicate sequence id errors #1809

merged 12 commits into from
Jul 25, 2024

Commits on Jul 11, 2024

  1. Add test for issue where input data is longer than the sequence lengt… 

    …h, and truncation is False, leading to duplicate sequence id's
    @dagardner-nv
    dagardner-nv committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    f8152f5 View commit details
    Browse the repository at this point in the history

  2. Add a preflight check and raise a value error if the input data is lo… 

    …nger than the sequence length, prevents building a seq_ids tensor with duplicate values
    @dagardner-nv
    dagardner-nv committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    ebf3457 View commit details
    Browse the repository at this point in the history

  3. Add fixtures for the bert vocab and hash files

    @dagardner-nv
    dagardner-nv committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    57a2f7d View commit details
    Browse the repository at this point in the history

  4. Use new bert fixtures

    @dagardner-nv
    dagardner-nv committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    627709f View commit details
    Browse the repository at this point in the history

  5. Add a test for the undefined error bug

    @dagardner-nv
    dagardner-nv committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    46e36f9 View commit details
    Browse the repository at this point in the history

  6. Fix for new_label and new_confidence variables being undefined

    @dagardner-nv
    dagardner-nv committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    3935074 View commit details
    Browse the repository at this point in the history

  7. Add a new line to make it clear that the line executes regardless of … 

    …the if-statement branch followed
    @dagardner-nv
    dagardner-nv committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    98f0fa0 View commit details
    Browse the repository at this point in the history

  8. Fix CR year

    @dagardner-nv
    dagardner-nv committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    8ad3fbb View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2024

  1. Merge branch 'branch-24.10' of github.com:nv-morpheus/Morpheus into d… 

    …avid-log-parsing-undefined-var
    @dagardner-nv
    dagardner-nv committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    901ddb3 View commit details
    Browse the repository at this point in the history

  2. Replace usage of warnings with a log at the warn level per PR feedback

    @dagardner-nv
    dagardner-nv committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    46adff5 View commit details
    Browse the repository at this point in the history

  3. Remove old print statement

    @dagardner-nv
    dagardner-nv committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    f978056 View commit details
    Browse the repository at this point in the history

  4. Update to test for logged warning

    @dagardner-nv
    dagardner-nv committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    250ab63 View commit details
    Browse the repository at this point in the history