Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update GNN FSI pipeline example & notebook. #182

Merged
19 commits merged into from
Jun 27, 2022
Merged

Update GNN FSI pipeline example & notebook. #182

19 commits merged into from
Jun 27, 2022

Conversation

tzemicheal
Copy link
Contributor

@tzemicheal tzemicheal commented Jun 23, 2022 •
edited
Loading

This updates the existing gnn pipeline.

  • Update xgboost model to fix the input mismatch during inference.
  • Removes and fixes eval script in tuning script.
  • Update gnn notebook.
  • Add graphsage model metadata.
  • Removes xgboost inference & replace with FIL.

@tzemicheal tzemicheal added the improvement Improvement to existing functionality label Jun 23, 2022
@tzemicheal tzemicheal self-assigned this Jun 23, 2022
@tzemicheal tzemicheal requested a review from a team as a code owner June 23, 2022 16:24
@mdemoret-nv mdemoret-nv requested a review from cwharris June 24, 2022 07:19
@tzemicheal tzemicheal marked this pull request as draft June 24, 2022 13:54
@tzemicheal tzemicheal changed the title Fsi gnn pipeline Update fsi gnn pipeline & notebook Jun 27, 2022
@tzemicheal tzemicheal changed the title Update fsi gnn pipeline & notebook Update GNN FSI pipeline example & notebook. Jun 27, 2022
@tzemicheal tzemicheal marked this pull request as ready for review June 27, 2022 16:37
@tzemicheal tzemicheal requested a review from a team as a code owner June 27, 2022 16:37
@tzemicheal tzemicheal added the non-breaking Non-breaking change label Jun 27, 2022
@tzemicheal
Merge branch 'fsi_gnn_pipeline' of github.com:tzemicheal/Morpheus int…
d3a592f 
…o fsi_gnn_pipeline

	models/training-tuning-scripts/fraud-detection-models/training.py
@tzemicheal
modified: models/training-tuning-scripts/fraud-detection-models/trai…
de02501 
…ning.py
mdemoret-nv
mdemoret-nv approved these changes Jun 27, 2022
View reviewed changes
Copy link
Contributor

@mdemoret-nv mdemoret-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the engineering side, this was mostly formatting changes. So it looks good.

raykallen
raykallen approved these changes Jun 27, 2022
View reviewed changes
Copy link
Contributor

@raykallen raykallen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mdemoret-nv
Copy link
Contributor

@gpucibot merge

@ghost ghost merged commit f6e9873 into nv-morpheus:branch-22.06 Jun 27, 2022
@mdemoret-nv mdemoret-nv mentioned this pull request Jun 28, 2022
Closed
@tzemicheal tzemicheal deleted the fsi_gnn_pipeline branch July 3, 2023 17:44
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raykallen raykallen raykallen approved these changes

@mdemoret-nv mdemoret-nv mdemoret-nv approved these changes

@cwharris cwharris Awaiting requested review from cwharris

Assignees

@tzemicheal tzemicheal

Labels
improvement Improvement to existing functionality non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tzemicheal @mdemoret-nv @raykallen