Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update isort settings file path in fix_all.sh #1855

Merged
merged 1 commit into from
Aug 21, 2024
Merged

Update isort settings file path in fix_all.sh #1855

merged 1 commit into from
Aug 21, 2024

Conversation

yczhang-nv
Copy link
Contributor

@yczhang-nv yczhang-nv commented Aug 20, 2024 •
edited
Loading

Description

Update isort settings file path in fix_all.sh to ${PROJ_TOML} so that this script finds the config path correctly.

This is a follow-up PR of #1854.

By Submitting this PR I confirm:

  • I am familiar with the Contributing Guidelines.
  • When the PR is ready for review, new or existing tests cover these changes.
  • When the PR is ready for review, the documentation is up to date with these changes.

@yczhang-nv yczhang-nv added bug Something isn't working non-breaking Non-breaking change labels Aug 20, 2024
@yczhang-nv yczhang-nv self-assigned this Aug 20, 2024
@yczhang-nv yczhang-nv requested a review from a team as a code owner August 20, 2024 23:36
dagardner-nv
dagardner-nv approved these changes Aug 20, 2024
View reviewed changes
Copy link
Contributor

@dagardner-nv dagardner-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Catch! Sorry I missed this one

@yczhang-nv
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 44f4d62 into nv-morpheus:branch-24.10 Aug 21, 2024
17 checks passed
@yczhang-nv yczhang-nv deleted the yuchen-update-fix-all-isort-settings-file branch August 21, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AnuradhaKaruppiah AnuradhaKaruppiah AnuradhaKaruppiah approved these changes

@dagardner-nv dagardner-nv dagardner-nv approved these changes

Assignees

@yczhang-nv yczhang-nv

Labels
bug Something isn't working non-breaking Non-breaking change
Projects
Morpheus Boards
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yczhang-nv @AnuradhaKaruppiah @dagardner-nv