-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run yapf, flake8, isort as part of pre-commit #1859
Merged
rapids-bot
merged 9 commits into
nv-morpheus:branch-24.10
from
cwharris:pre-commit-updates
Aug 30, 2024
Merged
Run yapf, flake8, isort as part of pre-commit #1859
rapids-bot
merged 9 commits into
nv-morpheus:branch-24.10
from
cwharris:pre-commit-updates
Aug 30, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwharris
added
non-breaking
Non-breaking change
improvement
Improvement to existing functionality
labels
Aug 23, 2024
@cwharris The changes looks good to me overall (thx for doing it! I am big fan of precommit) -
|
…re-commit-updates
…re-commit-updates
AnuradhaKaruppiah
approved these changes
Aug 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Couple of questions -
- Is ci/scripts/fix_all.sh still relevant? if yes, it needs to be updated
if [[ "${SKIP_YAPF}" == "" ]]; then
echo "Running yapf..."
python3 -m yapf -i --style ${PY_CFG} -r ${PY_MODIFIED_FILES[@]}
fi
- flake8 and yapf checks in morpheus.code-workspace need to change from setup.cfg to pyproject.toml
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #1702
By Submitting this PR I confirm: