Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run yapf, flake8, isort as part of pre-commit #1859

Merged
merged 9 commits into from
Aug 30, 2024

Conversation

cwharris
Copy link
Contributor

Description

Closes #1702

By Submitting this PR I confirm:

  • I am familiar with the Contributing Guidelines.
  • When the PR is ready for review, new or existing tests cover these changes.
  • When the PR is ready for review, the documentation is up to date with these changes.

@cwharris cwharris added non-breaking Non-breaking change improvement Improvement to existing functionality labels Aug 23, 2024
@cwharris cwharris requested review from a team as code owners August 23, 2024 18:29
@AnuradhaKaruppiah
Copy link
Contributor

@cwharris The changes looks good to me overall (thx for doing it! I am big fan of precommit) -

  1. The style fixups are going to conflict with PR-1853. It maybe easier to drop those commits and re-run precommit.
  2. Flake8 and yapf sections should be moved from setup.cfg to the toml file. I was going to address that separately but if it makes sense can you please get that change into this PR.

Copy link
Contributor

@AnuradhaKaruppiah AnuradhaKaruppiah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Couple of questions -

  1. Is ci/scripts/fix_all.sh still relevant? if yes, it needs to be updated
if [[ "${SKIP_YAPF}" == "" ]]; then
   echo "Running yapf..."
   python3 -m yapf -i --style ${PY_CFG} -r ${PY_MODIFIED_FILES[@]}
fi
  1. flake8 and yapf checks in morpheus.code-workspace need to change from setup.cfg to pyproject.toml

@cwharris
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 5a17b92 into nv-morpheus:branch-24.10 Aug 30, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement to existing functionality non-breaking Non-breaking change
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[FEA]: Add pre-commit hook for formatting of python and C++ code
2 participants