-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scripts for building and uploading the morpheus-core conda package #1883
Merged
rapids-bot
merged 6 commits into
nv-morpheus:branch-24.10
from
AnuradhaKaruppiah:morpheus-core-package
Sep 6, 2024
Merged
Scripts for building and uploading the morpheus-core conda package #1883
rapids-bot
merged 6 commits into
nv-morpheus:branch-24.10
from
AnuradhaKaruppiah:morpheus-core-package
Sep 6, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anuradha Karuppiah <anuradhak@nvidia.com>
Signed-off-by: Anuradha Karuppiah <anuradhak@nvidia.com>
This is a workaround to the following error - >>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>> CMake Error at build-conda/_deps/rapids-cmake-src/rapids-cmake/cmake/make_global.cmake:59 (set_target_properties):^M Attempt to promote imported target "gflags" to global scope (by setting^M IMPORTED_GLOBAL) which is not built in this directory.^M Call Stack (most recent call first):^M build-conda/_deps/rapids-cmake-src/rapids-cmake/find/package.cmake:129 (rapids_cmake_make_global)^M /Morpheus/.cache/cpm/mrc/9f8a50df0cf94cf470a5cdc01861ed63f701e27f/cmake/dependencies.cmake:53 (rapids_find_package)^M /Morpheus/.cache/cpm/mrc/9f8a50df0cf94cf470a5cdc01861ed63f701e27f/CMakeLists.txt:148 (include) >>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>> Signed-off-by: Anuradha Karuppiah <anuradhak@nvidia.com>
Signed-off-by: Anuradha Karuppiah <anuradhak@nvidia.com>
/ok to test |
1 similar comment
/ok to test |
0826860
to
082560b
Compare
/ok to test |
1. The morpheus-core conda package is built for main/dev branches and when "conda-core-build" label is added to the PR. 2. Enabled upload of morpheus-core conda package. The conda package with all morpheus compoments (core+llm) can still be built via the usual triggers. Uploading that package remains disabled. Signed-off-by: Anuradha Karuppiah <anuradhak@nvidia.com>
082560b
to
0badf40
Compare
/ok to test |
dagardner-nv
approved these changes
Sep 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just a few comments/questions
Updated the "morpheus" conda-package job to not upload (it was earlier relying on conda_upload_label being empty to skip upload). Signed-off-by: Anuradha Karuppiah <anuradhak@nvidia.com>
/ok to test |
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
conda-build
Enables running the conda-build step on a PR
feature request
New feature or request
non-breaking
Non-breaking change
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change two conda packages are generated -
The morpheus-core package is uploaded to anaconda.org/nvidia for use by applications.
A new PR label "conda-core-build" is available to trigger building the morpheus-core conda package as a part of the CI pipeline.
Testing done:
Generated the morpheus-core conda package via -
a. local ci runner -
b. docker build -
And verified an application that uses the core stages.