Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollback CI images and fix dev container #191

Merged
1 commit merged into from
Jun 24, 2022

Conversation

cwharris
Copy link
Contributor

Rolls back the ci images to 22.04 and removes the ci build fix necessary for those images, because the fixes are causing issues for compilations done from within the dev container.

Closes #190

@cwharris cwharris added bug Something isn't working non-breaking Non-breaking change 4 - Waiting on Reviewer labels Jun 24, 2022
@cwharris cwharris marked this pull request as ready for review June 24, 2022 17:06
@cwharris cwharris requested review from a team as code owners June 24, 2022 17:06
@cwharris cwharris changed the base branch from branch-22.08 to branch-22.06 June 24, 2022 17:07
Copy link
Contributor

@mdemoret-nv mdemoret-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one suggestion to keep the CMake changes to stay in sync with SRF.

CMakeLists.txt Show resolved Hide resolved
@mdemoret-nv
Copy link
Contributor

@gpucibot merge

@ghost ghost merged commit 75fcb9f into nv-morpheus:branch-22.06 Jun 24, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Unable to build Morpheus in DEV container
2 participants