Improve SharedProcessPool tests performance
#1950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yczhang-nv
added
non-breaking
…red-process-pool-tests
yczhang-nv
changed the title
SharedProcessPool tests to run fasterSharedProcessPool tests performance
mdemoret-nv
approved these changes
Oct 21, 2024
…red-process-pool-tests
|
/ok to test |
|
/ok to test |
|
/ok to test |
mdemoret-nv
approved these changes
Nov 20, 2024
|
/ok to test |
|
/ok to test |
|
/ok to test |
|
/ok to test |
|
/ok to test |
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some minor improvements to make
SharedProcessPoolrelated tests to run faster. Those are mostly combining multiple tests into one unit test function to reduce the number of times that the process pool being initialized and reset.The total execution time of
test_shared_process_pool.pyandtest_multi_processing_stage.pyshould be improved from ~60s to ~30s (when running locally).Closes #1951
By Submitting this PR I confirm: