Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove TRT optimization from all-MiniLM-L6-v2 #2143

Conversation

efajardo-nv
Copy link
Contributor

@efajardo-nv efajardo-nv commented Jan 28, 2025

Description

Closes #1649

By Submitting this PR I confirm:

  • I am familiar with the Contributing Guidelines.
  • When the PR is ready for review, new or existing tests cover these changes.
  • When the PR is ready for review, the documentation is up to date with these changes.

@efajardo-nv efajardo-nv added bug Something isn't working non-breaking Non-breaking change labels Jan 28, 2025
@efajardo-nv efajardo-nv requested a review from a team as a code owner January 28, 2025 19:58
@dagardner-nv
Copy link
Contributor

Does this PR fix #1649? If so can you update the PR to indicate that it does, and remove the reference to the bug in docs/source/extra_info/known_issues.md

@efajardo-nv
Copy link
Contributor Author

Does this PR fix #1649? If so can you update the PR to indicate that it does, and remove the reference to the bug in docs/source/extra_info/known_issues.md
Yes appears so. Not seeing that error and no longer using tensorrt which is referenced by the error.

@efajardo-nv efajardo-nv requested a review from a team as a code owner January 28, 2025 20:39
@dagardner-nv
Copy link
Contributor

/merge

@rapids-bot rapids-bot bot merged commit 830bdb0 into nv-morpheus:branch-25.02 Jan 31, 2025
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working non-breaking Non-breaking change
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants