Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update NLP SI example readme #284

Merged
3 commits merged into from
Jul 25, 2022
Merged

Update NLP SI example readme #284

3 commits merged into from
Jul 25, 2022

Conversation

pdmack
Copy link
Contributor

@pdmack pdmack commented Jul 18, 2022

Similar set of changes found elsewhere to account for data dir relocations.
Relates to #232 and #242

Similar set of changes found elsewhere to account for data dir relocations.
Relates to #232 and #242
@pdmack pdmack added non-breaking Non-breaking change doc Improvements or additions to documentation 3 - Ready for Review labels Jul 18, 2022
@pdmack pdmack requested a review from a team as a code owner July 18, 2022 16:36
Copy link
Contributor

@cwharris cwharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

examples/nlp_si_detection/README.md Outdated Show resolved Hide resolved
examples/nlp_si_detection/README.md Outdated Show resolved Hide resolved
Misfire on the examples path
@pdmack
Copy link
Contributor Author

pdmack commented Jul 25, 2022

@mdemoret-nv @dagardner-nv PTAL

@pdmack pdmack requested a review from dagardner-nv July 25, 2022 19:23
Copy link
Contributor

@dagardner-nv dagardner-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@pdmack
Copy link
Contributor Author

pdmack commented Jul 25, 2022

@gpucibot merge

@ghost ghost merged commit fddfaf9 into branch-22.08 Jul 25, 2022
@ghost ghost deleted the pdmack-patch-3 branch July 25, 2022 20:08
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Improvements or additions to documentation non-breaking Non-breaking change
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants