Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

operational-technology-use-case #35

Merged
merged 11 commits into from
Feb 24, 2023
Merged

Conversation

gbatmaz
Copy link
Contributor

@gbatmaz gbatmaz commented Feb 10, 2023

Operational technology attack/fault detection notebook, scripts and an example model.
closes issue #36

@gbatmaz gbatmaz requested a review from a team as a code owner February 10, 2023 13:58
@gbatmaz gbatmaz added feature request New feature or request non-breaking Non-breaking change labels Feb 10, 2023
@gbatmaz gbatmaz assigned gbatmaz and unassigned raykallen Feb 10, 2023
Copy link
Contributor

@tzemicheal tzemicheal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added few comments to OT PR, thanks.

Could you add title & info of the usecase at the main README file for the operational technology usecase

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@gbatmaz
Copy link
Contributor Author

gbatmaz commented Feb 24, 2023

I added few comments to OT PR, thanks.

Could you add title & info of the usecase at the main README file for the operational technology usecase

Thank you! Just pushed a commit for this

@tzemicheal
Copy link
Contributor

LGTM!

operational-technology/README.md Outdated Show resolved Hide resolved
operational-technology/README.md Outdated Show resolved Hide resolved
operational-technology/README.md Outdated Show resolved Hide resolved
operational-technology/README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@raykallen raykallen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@raykallen
Copy link
Contributor

/merge

@rapids-bot rapids-bot bot merged commit 88253d9 into nv-morpheus:branch-23.03 Feb 24, 2023
@tzemicheal tzemicheal mentioned this pull request Feb 27, 2023
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants