Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate CLX DGA Detection #46

Merged
merged 30 commits into from
Jun 5, 2023

Conversation

efajardo-nv
Copy link
Contributor

@efajardo-nv efajardo-nv commented May 2, 2023

Description

  • Migrate code, notebook, dataset for CLX DGA Detection
  • Remove references to CLX
  • Example Morpheus pipeline
  • Triton model repo with ONNX model
  • Fix bug in existing code caused by upstream cudf updates
  • Add new training and validation data
  • Merge version updates from PR Update versions in container to match Morpheus #49
  • Remove cuml dependency so scripts/notebooks can also be run in Morpheus container

Task from nv-morpheus/Morpheus#508

Checklist

[x] I am familiar with the Contributing Guidelines.
[x] New or existing tests cover these changes.
[x] The documentation is up to date with these changes.

@efajardo-nv efajardo-nv requested a review from a team as a code owner May 2, 2023 22:46
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@efajardo-nv efajardo-nv added feature request New feature or request non-breaking Non-breaking change labels May 2, 2023
@efajardo-nv efajardo-nv marked this pull request as draft May 3, 2023 15:43
@efajardo-nv efajardo-nv marked this pull request as ready for review May 26, 2023 19:44
dga-detection/README.md Outdated Show resolved Hide resolved
dga-detection/morpheus-pipeline/messages.py Outdated Show resolved Hide resolved
dga-detection/morpheus-pipeline/preprocessing.py Outdated Show resolved Hide resolved
Copy link
Contributor

@mdemoret-nv mdemoret-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge once the comment has been fixed

dga-detection/morpheus-pipeline/preprocessing.py Outdated Show resolved Hide resolved
@efajardo-nv
Copy link
Contributor Author

/merge

1 similar comment
@raykallen
Copy link
Contributor

/merge

@raykallen
Copy link
Contributor

/merge

1 similar comment
@raykallen
Copy link
Contributor

/merge

@rapids-bot rapids-bot bot merged commit f59aada into nv-morpheus:branch-23.07 Jun 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request non-breaking Non-breaking change
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants