Skip to content

Commit

Permalink
Fix 'flickUp' text review touch gesture (#15171)
Browse files Browse the repository at this point in the history
Closes #15127
Fix up of #14021

Summary of the issue:
#14021 accidentally overwrote the touch gesture to move to the previous line in text review mode.
These overwritten gestures were not documented in the user guide, and appear to be unintentional.

Description of user facing changes
Remove overwritten "flickUp" gestures.

Description of development approach
Remove overwritten "flickUp" gestures.
  • Loading branch information
seanbudd authored Jul 21, 2023
1 parent c4ca763 commit 9157916
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
6 changes: 3 additions & 3 deletions source/globalCommands.py
Original file line number Diff line number Diff line change
Expand Up @@ -273,7 +273,7 @@ def script_reportCurrentSelection(self,gesture):
speech.speakMessage(_("No selection"))
else:
speech.speakTextSelected(info.text)


@script(
# Translators: Input help mode message for report date and time command.
description=_("If pressed once, reports the current time. If pressed twice, reports the current date"),
Expand Down Expand Up @@ -1591,7 +1591,7 @@ def script_review_nextLine(self, gesture: inputCore.InputGesture):
description=_("Moves the review cursor to the previous page of the current navigator object and speaks it"),
resumeSayAllMode=sayAll.CURSOR.REVIEW,
category=SCRCAT_TEXTREVIEW,
gestures=("kb:NVDA+pageUp", "kb(laptop):NVDA+shift+pageUp", "ts(text):flickUp")
gestures=("kb:NVDA+pageUp", "kb(laptop):NVDA+shift+pageUp")
)
def script_review_previousPage(self, gesture: inputCore.InputGesture) -> None:
info = api.getReviewPosition().copy()
Expand Down Expand Up @@ -1623,7 +1623,7 @@ def script_review_previousPage(self, gesture: inputCore.InputGesture) -> None:
description=_("Moves the review cursor to the next page of the current navigator object and speaks it"),
resumeSayAllMode=sayAll.CURSOR.REVIEW,
category=SCRCAT_TEXTREVIEW,
gestures=("kb:NVDA+pageDown", "kb(laptop):NVDA+shift+pageDown", "ts(text):flickUp")
gestures=("kb:NVDA+pageDown", "kb(laptop):NVDA+shift+pageDown")
)
def script_review_nextPage(self, gesture: inputCore.InputGesture) -> None:
origInfo = api.getReviewPosition().copy()
Expand Down
1 change: 1 addition & 0 deletions user_docs/en/changes.t2t
Original file line number Diff line number Diff line change
Expand Up @@ -128,6 +128,7 @@ This can be disabled in the Advanced Settings panel. (#7756)
- NVDA now generally responds slightly faster to commands and focus changes. (#14928)
- Displaying the OCR settings will not fail on some systems anymore. (#15017)
- Fix bug related to saving and loading the NVDA configuration, including switching synthesizers. (#14760)
- Fix bug causing text review "flick up" touch gesture to move pages rather than move to previous line. (#15127)
-


Expand Down

0 comments on commit 9157916

Please sign in to comment.