Skip to content

Commit

Permalink
Revert "Use UIA caret events in Windows Terminal (#16873)" (#17048)
Browse files Browse the repository at this point in the history
Reverts #16873.

Summary of the issue:
When backspacing beyond the leftmost character of a line in Windows Terminal, the last character of the prompt is erroneously read in some environments.
Some caret tracking issues (especially when connected to remote systems) are more apparent.
Description of how this pull request fixes the issue:
Revert the new behaviour until it can be fixed upstream or a workaround can be found.

Testing strategy:
Verified restoration of previous behaviour and that caret tracking works as before.
  • Loading branch information
codeofdusk authored Aug 27, 2024
1 parent be10321 commit 9d95367
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions source/NVDAObjects/UIA/winConsoleUIA.py
Original file line number Diff line number Diff line change
Expand Up @@ -450,10 +450,6 @@ def event_UIA_notification(self, **kwargs):
"Block notification events when diffing to prevent double reporting."
log.debugWarning(f"Notification event blocked to avoid double-report: {kwargs}")

def _get_caretMovementDetectionUsesEvents(self) -> bool:
"Windows Terminal has a good implementation of caret move detection."
return True


class _NotificationsBasedWinTerminalUIA(UIA):
"""
Expand Down

0 comments on commit 9d95367

Please sign in to comment.