Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

after making new api public function, vision providers are not opening #15142

Closed
zstanecic opened this issue Jul 14, 2023 · 2 comments · Fixed by #15151
Closed

after making new api public function, vision providers are not opening #15142

zstanecic opened this issue Jul 14, 2023 · 2 comments · Fixed by #15151
Labels
bug/regression p2 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority triaged Has been triaged, issue is waiting for implementation.
Milestone

Comments

@zstanecic
Copy link
Contributor

Steps to reproduce:

  1. upgrade to latest alpha,
  2. try to start it. You will hear few error sounds
  3. try to open settings, and navigate to vision section

Actual behavior:

we hear error sound, and we have the following log:
ERROR - vision.visionHandler._getProvidersFromFileSystem (13:08:30.611) - MainThread (4400):
Error while importing vision enhancement provider module NVDAHighlighter
Traceback (most recent call last):
File "vision\visionHandler.pyc", line 58, in _getProvidersFromFileSystem
File "vision\visionHandler.pyc", line 36, in getProviderClass
File "importlib_init
.pyc", line 127, in import_module
File "", line 1006, in _gcd_import
File "", line 983, in _find_and_load
File "", line 967, in _find_and_load_unlocked
File "", line 668, in _load_unlocked
File "", line 638, in _load_backward_compatible
File "visionEnhancementProviders\NVDAHighlighter.pyc", line 242, in
AttributeError: module 'gui' has no attribute 'AutoSettingsMixin'
ERROR - vision.visionHandler._getProvidersFromFileSystem (13:08:30.639) - MainThread (4400):
Error while importing vision enhancement provider module screenCurtain
Traceback (most recent call last):
File "vision\visionHandler.pyc", line 58, in _getProvidersFromFileSystem
File "vision\visionHandler.pyc", line 36, in getProviderClass
File "importlib_init
.pyc", line 127, in import_module
File "", line 1006, in _gcd_import
File "", line 983, in _find_and_load
File "", line 967, in _find_and_load_unlocked
File "", line 668, in _load_unlocked
File "", line 638, in _load_backward_compatible
File "visionEnhancementProviders\screenCurtain.pyc", line 218, in
AttributeError: module 'gui' has no attribute 'AutoSettingsMixin'
ERROR - queueHandler.flushQueue (13:08:30.664) - MainThread (4400):
Error in func VisionHandler.postGuiInit
Traceback (most recent call last):
File "queueHandler.pyc", line 64, in flushQueue
File "vision\visionHandler.pyc", line 96, in postGuiInit
File "vision\visionHandler.pyc", line 119, in _updateAllProvidersList
File "vision\visionHandler.pyc", line 103, in _getBuiltInProviderIds
File "", line 983, in _find_and_load
File "", line 967, in _find_and_load_unlocked
File "", line 668, in _load_unlocked
File "", line 638, in _load_backward_compatible
File "visionEnhancementProviders\NVDAHighlighter.pyc", line 242, in
AttributeError: module 'gui' has no attribute 'AutoSettingsMixin'
AttributeError: module 'gui' has no attribute 'AutoSettingsMixin'
ERROR - unhandled exception (13:13:42.289) - MainThread (4400):
Traceback (most recent call last):
File "gui\settingsDialogs.pyc", line 4312, in onCategoryChange
File "gui\settingsDialogs.pyc", line 693, in onCategoryChange
File "gui\settingsDialogs.pyc", line 675, in _doCategoryChange
File "gui\settingsDialogs.pyc", line 603, in _getCategoryPanel
File "gui\settingsDialogs.pyc", line 361, in init
File "gui\settingsDialogs.pyc", line 371, in _buildGui
File "gui\settingsDialogs.pyc", line 4025, in makeSettings
File "vision\visionHandler.pyc", line 138, in getProviderList
File "vision\visionHandler.pyc", line 119, in _updateAllProvidersList
File "vision\visionHandler.pyc", line 103, in _getBuiltInProviderIds
File "", line 983, in _find_and_load
File "", line 967, in _find_and_load_unlocked
File "", line 668, in _load_unlocked
File "", line 638, in _load_backward_compatible
File "visionEnhancementProviders\NVDAHighlighter.pyc", line 242, in
AttributeError: module 'gui' has no attribute 'AutoSettingsMixin'

Expected behavior:

vision providers should work and they shold be displayed.

NVDA logs, crash dumps and other attachments:

System configuration

NVDA installed/portable/running from source:

installed

NVDA version:

alpha-28685,a8b79c76

Windows version:

windows 11, 22H2, Windows 11 22H2 (10.0.23493) workstation AMD64

Name and version of other software in use when reproducing the issue:

n/a

Other information about your system:

Other questions

Does the issue still occur after restarting your computer?

yes

Have you tried any other versions of NVDA? If so, please report their behaviors.

yes, older alpha before new api breakage.

If NVDA add-ons are disabled, is your problem still occurring?

yes

Does the issue still occur after you run the COM Registration Fixing Tool in NVDA's tools menu?

yes

@amirsol81
Copy link

I can duplicate this. So Braille-related items show up under my Vision pane of the Settings window with the latest Alpha.

@LeonarddeR LeonarddeR added bug/regression p2 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority triaged Has been triaged, issue is waiting for implementation. labels Jul 15, 2023
@LeonarddeR LeonarddeR added this to the 2023.2 milestone Jul 15, 2023
@Brian1Gaff
Copy link

Brian1Gaff commented Jul 15, 2023 via email

seanbudd added a commit that referenced this issue Jul 17, 2023
Follow up to #15121

Fixes #15142
Fixes #15141
Fixes #15148
Fixes #15147

Summary of the issue:
PR #15121 to fix #15120 had various unexpected side effects.
This is due to symbols that were previously star imported into gui/__init__.py being removed.
Add-ons and the vision enhancements core module relied on these symbols being imported.
While there was no API breaking changes, these changes affected over 30 add-ons

Description of user facing changes
Fix up issue with vision enhancement providers, such as opening the relevant settings panels.

Description of development approach
Add aliases for SettingsPanel, AutoSettingsMixin, _popupSettingsDialog in gui
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug/regression p2 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority triaged Has been triaged, issue is waiting for implementation.
Projects
None yet
4 participants