Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Developer guide has incorrect value in lang attribute. #16487

Closed
gauravahir28 opened this issue May 6, 2024 · 0 comments · Fixed by #16563
Closed

Developer guide has incorrect value in lang attribute. #16487

gauravahir28 opened this issue May 6, 2024 · 0 comments · Fixed by #16563
Labels
bug/regression component/documentation p3 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority triaged Has been triaged, issue is waiting for implementation.
Milestone

Comments

@gauravahir28
Copy link

I'm not sure where to report this, for now reporting it here, please let me know the correct place incase this issue isn't accepted here.

Steps to reproduce:

  • Open the developer guide .
  • Inspect the lang attribute provided on <html> tag.

Actual behavior:

currently the lang attribute have "developerGuide" value which is incorrect.

Expected behavior:

The lang attribute should have valid language value such as "en" for English.

NVDA logs, crash dumps and other attachments:

System configuration

NVDA installed/portable/running from source:

N/A

NVDA version:

N/A

Windows version:

Windows 11 23H2

Name and version of other software in use when reproducing the issue:

Chrome latest

Other information about your system:

Other questions

Does the issue still occur after restarting your computer?

N/A

Have you tried any other versions of NVDA? If so, please report their behaviors.

N/A

If NVDA add-ons are disabled, is your problem still occurring?

N/A

Does the issue still occur after you run the COM Registration Fixing Tool in NVDA's tools menu?

N/A

@seanbudd seanbudd added this to the 2024.2 milestone May 6, 2024
@seanbudd seanbudd added bug/regression component/documentation p3 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority triaged Has been triaged, issue is waiting for implementation. labels May 6, 2024
seanbudd added a commit that referenced this issue May 20, 2024
Fixes #16487

Summary of the issue:
currently the lang attribute for the developerGuide has the value "developerGuide": nvaccess.org/files/nvda/releases/2024.1/documentation/developerGuide.html

This is because the parent folder name is used to determine the lang code, which is true for other docs.

Description of user facing changes
Fix lang code for the developer Guide

Description of development approach
Fix lang code for the developer Guide
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug/regression component/documentation p3 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority triaged Has been triaged, issue is waiting for implementation.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants