Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

App modules/developer info: log app architecture property #16488

Closed
josephsl opened this issue May 6, 2024 · 0 comments · Fixed by #16972
Closed

App modules/developer info: log app architecture property #16488

josephsl opened this issue May 6, 2024 · 0 comments · Fixed by #16972
Labels
architecture/x64 audience/nvda-dev PR or issue is relevant to NVDA / Add-on developers component/logging p5 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority triaged Has been triaged, issue is waiting for implementation.
Milestone
2024.4

Comments

@josephsl
Copy link
Collaborator

josephsl commented May 6, 2024

Hi,

MOstly to help ARM64 users and testers:

Rationale

Microsoft, Google, and other app vendors are starting to provide native ARM64 applications for use on Windows 10 and later. Coupled with support for x86 apps (and AMD64 apps on Windows 11), it becomes important to help develoeprs and users figure out which app architecture is in use.

Is your feature request related to a problem? Please describe.

Currently, app architecture property in app modules is not logged unlike product name, version, and helper binding handle. To see the app architecture, one must enter Python Console (Control+NVDA+Z) and type "focus.appModule.appArchitecture" (without quotes) and press Enter.

Describe the solution you'd like

Log appModule.appArchitecture property as part of developer info for navigator object.

Describe alternatives you've considered

Do not log app architecture (see the current procedure above).

Additional context

This can be a useful way to assist with #16304 once both 32-bit and 64-bit NVDA are in use, as well as help debug app issues on Windows 10/11 on ARM64.

Thanks.
@seanbudd seanbudd added p5 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority component/logging audience/nvda-dev PR or issue is relevant to NVDA / Add-on developers triaged Has been triaged, issue is waiting for implementation. labels May 6, 2024
josephsl added a commit to josephsl/nvda that referenced this issue Aug 8, 2024
@josephsl
app modules: update copyright header, add ap architecture to dev info…
08d6859 
…. Re nvaccess#16488.

Useful on ARM64: log app architecture (x86, AMD64, ARM64) as part of navigator object dev info.
josephsl added a commit to josephsl/nvda that referenced this issue Aug 8, 2024
@josephsl
Changelog: add app architecture entry (changes for devleopers). Re nv…
d3f3875 
…access#16488
@josephsl josephsl mentioned this issue Aug 8, 2024
Merged
5 tasks
seanbudd pushed a commit that referenced this issue Aug 8, 2024
@josephsl
App modules: log app architecture as part of dev info (#16972)
ef4fb41 
Closes #16488

Summary of the issue:
Log app architecture as part of app module info.

Description of user facing changes
For developers: developer info for navigator object now includes app architecture for the current app.

Description of development approach
Added apModule.appArchitecture to dev info list in app module class.
@github-actions github-actions bot added this to the 2024.4 milestone Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
architecture/x64 audience/nvda-dev PR or issue is relevant to NVDA / Add-on developers component/logging p5 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority triaged Has been triaged, issue is waiting for implementation.
Projects
None yet
Milestone
2024.4
Development

Successfully merging a pull request may close this issue.

App modules: log app architecture as part of dev info josephsl/nvda
2 participants
@seanbudd @josephsl