-
-
Notifications
You must be signed in to change notification settings - Fork 654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve the report link feature #17127
Comments
If implemented for local files and CHM help systems, this would make such announcements more consistent. JAWS also covers these instances. |
I'll create a PR when this is triaged. |
To a user, a web page is a web page, whether it is local or remote. So I support this issue.
On the other topic: There is too much potential for query strings to change what the page displays. Better not to risk it.
|
Luke wrote:
This reasoning is almost undebatable for me. |
Fixes issue #17127 Fixup of PR #16994 Summary of the issue: Same page links are reported, but not on local files. Description of user facing changes: Same page links will be also reported on local files like HTML documents. Description of development approach: In the `samePageURL` function, "file" has been added to `validSchemes`. Testing strategy: - Tested manually with NVDA's user guide. - Performed unit tests.
Is your feature request related to a problem? Please describe.
Links to the same page are reported for
http
andhttps
schemes, and this doesn't include local files like the NVDA's user guide.Describe the solution you'd like
Same page links should be reported also for local files.
Describe alternatives you've considered
Report link types just for non local webpages.
Additional context
This feature has been included in pr #16994, to fix issue #141.
Other refinements may be suggested in the future. For example, when we see if this works consistently in webpages with query parameters and if this should be improved for such wwebpages..
The text was updated successfully, but these errors were encountered: