Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the report link feature #17127

Closed
nvdaes opened this issue Sep 6, 2024 · 4 comments · Fixed by #17161
Closed

Improve the report link feature #17127

nvdaes opened this issue Sep 6, 2024 · 4 comments · Fixed by #17161
Labels
p4 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority triaged Has been triaged, issue is waiting for implementation.
Milestone

Comments

@nvdaes
Copy link
Collaborator

nvdaes commented Sep 6, 2024

Is your feature request related to a problem? Please describe.

Links to the same page are reported for http and https schemes, and this doesn't include local files like the NVDA's user guide.

Describe the solution you'd like

Same page links should be reported also for local files.

Describe alternatives you've considered

Report link types just for non local webpages.

Additional context

This feature has been included in pr #16994, to fix issue #141.

Other refinements may be suggested in the future. For example, when we see if this works consistently in webpages with query parameters and if this should be improved for such wwebpages..

@amirsol81
Copy link

If implemented for local files and CHM help systems, this would make such announcements more consistent. JAWS also covers these instances.

@nvdaes
Copy link
Collaborator Author

nvdaes commented Sep 6, 2024

I'll create a PR when this is triaged.
For me it has been a good idea to merge this early, so that it can be tested by more users.
I'm testing locally with the proposed changes enabling the reporting of same page links in the user guide.
I've also tested removing query parameters for comparison between root and target URL, but I think it's better not to remove them, even when some same pages in certain cases aren't identified as such if query parameters are found.

@XLTechie
Copy link
Collaborator

XLTechie commented Sep 6, 2024 via email

@nvdaes
Copy link
Collaborator Author

nvdaes commented Sep 7, 2024

Luke wrote:

To a user, a web page is a web page, whether it is local or remote.

This reasoning is almost undebatable for me.
Let's wait for this to be triaged.

@seanbudd seanbudd added p4 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority triaged Has been triaged, issue is waiting for implementation. labels Sep 10, 2024
@SaschaCowley SaschaCowley linked a pull request Sep 18, 2024 that will close this issue
5 tasks
SaschaCowley pushed a commit that referenced this issue Sep 18, 2024
Fixes issue #17127
Fixup of PR #16994

Summary of the issue:
Same page links are reported, but not on local files.

Description of user facing changes:
Same page links will be also reported on local files like HTML documents.

Description of development approach:
In the `samePageURL` function, "file" has been added to `validSchemes`.

Testing strategy:
- Tested manually with NVDA's user guide.
- Performed unit tests.
@github-actions github-actions bot added this to the 2025.1 milestone Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p4 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority triaged Has been triaged, issue is waiting for implementation.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants