Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Braille indication of font attributes using dots 7/8 #7097

Open
JordyDew opened this issue Apr 24, 2017 · 15 comments
Open

Braille indication of font attributes using dots 7/8 #7097

JordyDew opened this issue Apr 24, 2017 · 15 comments
Labels
component/braille p5 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority triaged Has been triaged, issue is waiting for implementation.

Comments

@JordyDew
Copy link

It would be fine if NVDA indicates bold, italic, underlined, ... text in braille, as it does in speech output.
Something like JAWS, where all those things are underlined with dots seven and eight, would be very nice.
And regardless of which braille table is used. It's difficult for me to use the UEB tables, becaus I never learnt to read literal braille correctly. I usually use the German 8 dots braille table, but there, we don't have any options to see formatting in braille.
I, and others, need this in several: studying, preparing a paper, writing an official letter, telling a story,...

@josephsl
Copy link
Collaborator

josephsl commented Apr 24, 2017 via email

@LeonarddeR
Copy link
Collaborator

cc @dkager

The following issues seem to be relevant here:

It somehow turns out that this is a duplicate of #538, but I agree with @JordyDew and @gregjozk that the fix in #538 is far from ideal.

@josephsl: I do not see a valid reason to close this

@dkager
Copy link
Collaborator

dkager commented Apr 25, 2017

There is an underlying issue, liblouis doesn't currently support augmenting cells with certain dots for certain attributes.

A few more things to consider:

  • Dots 7 & 8 are already used to indicate selection, so this could get confusing.
  • Just dot 8 is another popular option.
  • We'd need a way to map attributes to dots.
  • It would probably be useful to have a command to report the formatting under the braille cursor routing key being pressed. Jsut seeing dots 7 & 8 still doesn't tell you if it's bold, italic, etc.

@josephsl
Copy link
Collaborator

josephsl commented Apr 25, 2017 via email

@derekriemer
Copy link
Collaborator

derekriemer commented Apr 25, 2017 via email

@jcsteh
Copy link
Contributor

jcsteh commented Apr 25, 2017

@leonardder commented on 25 Apr. 2017, 5:27 pm AEST:

It somehow turns out that this is a duplicate of #538, but I agree with @JordyDew and @gregjozk that the fix in #538 is far from ideal.

I'd still argue #538 is the correct "default" behaviour. Underlining emphasis is not part of any braille standard; it's a convention. It's also ambiguous. Still, happy to accept that people might want this to be configurable for efficiency and for tables which don't support emphasis.

@dkager commented on 25 Apr. 2017, 11:40 pm AEST:

There is an underlying issue, liblouis doesn't currently support augmenting cells with certain dots for certain attributes.

True enough, though we can work around this like we do for selection I think.

  • We'd need a way to map attributes to dots.

I don't quite follow this. Can you elaborate?

  • It would probably be useful to have a command to report the formatting under the braille cursor routing key being pressed. Jsut seeing dots 7 & 8 still doesn't tell you if it's bold, italic, etc.

Agreed. From an implementation perspective, I think we'd need to add a method to get a TextInfo from a routing index. Duplicating formatting reporting code in both globalCommands and braille sounds ugly to me. That said, this should probably be split into a separate piece of work.

@derekriemer commented on 26 Apr. 2017, 3:08 am AEST:

What about using braille weight to do emphasis?

I know some displays can change braille weight, but I think it's across the entire display, not for individual cells. Regardless, many cells don't have configurable weight at all.

@jcsteh jcsteh changed the title Feature request: braille indication of lay-out Braille indication of font attributes using dots 7/8 Apr 25, 2017
@jcsteh jcsteh added the p5 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority label Apr 25, 2017
@JordyDew
Copy link
Author

JordyDew commented Apr 26, 2017 via email

@jcsteh
Copy link
Contributor

jcsteh commented Apr 26, 2017 via email

@dkager
Copy link
Collaborator

dkager commented Apr 26, 2017

We'd need a way to map attributes to dots.

I don't quite follow this. Can you elaborate?

First you'd need a way to define which attributes are shown, e.g. only bold or bold and italic, etc. Second, I believe some screen readers also offer dot 8 as an indicator, e.g. for reporting the accelerator key for menu items. So maybe someone could set italic to dots 7 & 8 and bold to dot 8? Just a thought, this is definitely not standard behavior.
If there is some kind of standard behavior, it could be nice to add that to computer braille tables in liblouis so that more people benefit. But as Jamie said I don't think such a standard exists.

@jcsteh
Copy link
Contributor

jcsteh commented Apr 26, 2017 via email

@dkager
Copy link
Collaborator

dkager commented Apr 26, 2017

Hah, just trying to scope this. :)

Most other attributes (links, editor revisions) can be dealt with using start/end indicators. This is more consistent anyway. Related: #6785.
Spelling errors could also be shown with start/end indicators, however I believe @LeonarddeR wants to underline them. This makes sense if only part of a word can be marked as spelling/grammar error. I don't know if that's possible. If not, I'd say underlining should be reserved for font styles only.
In that case it's probably enough to have an underline on/off toggle. You then configure what you want to see in the document formatting settings.

@gregjozk
Copy link
Contributor

gregjozk commented Apr 26, 2017 via email

@albzan
Copy link

albzan commented Jun 13, 2017

Hi,
If anyone is interested to test or improve it, I've developed an addon for myself that implements braille attributes with dots 7 and 8.
More info at:
https://github.com/albzan/attribra/
It does not provide a comfortable GUI and so it is a bit rough to configure for a normal user (you have to edit an ini file).
Maybe someone could find it interesting or want to contribute on it.
Regards,
Alberto

@LeonarddeR
Copy link
Collaborator

I think demand for this issue has become less now braille extender by @Andre9642 has become a quite popular add-on. I believe the code for this is also based on the add-on by @albzan.

Still, I think that this functionality belongs in core as long as the liblouis way of presenting formatting information to the user is the default and the preferred method.

NVDA's braille support has been heavily improved over the past few years, and because of this, this issue is getting more and more prominent on the list of features people would like to see.

@zstanecic
Copy link
Contributor

zstanecic commented Sep 15, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/braille p5 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority triaged Has been triaged, issue is waiting for implementation.
Projects
None yet
Development

No branches or pull requests