Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI Automation in Windows Console: Always use ConsoleUIATextInfo in UIA consoles #10052

Merged
merged 4 commits into from
Aug 13, 2019
Merged

UI Automation in Windows Console: Always use ConsoleUIATextInfo in UIA consoles #10052

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
47765af
_TextInfo -> TextInfo
codeofdusk Aug 8, 2019
6ff510a
Review action.
codeofdusk Aug 12, 2019
4864469
Update source/NVDAObjects/UIA/winConsoleUIA.py
codeofdusk Aug 13, 2019
f94c539
Style.
codeofdusk Aug 13, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion source/NVDAObjects/UIA/winConsoleUIA.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,10 +235,16 @@ class WinConsoleUIA(KeyboardHandlerBasedTypedCharSupport):
#: Only process text changes every 30 ms, in case the console is getting
#: a lot of text.
STABILIZE_DELAY = 0.03
_TextInfo = consoleUIATextInfo
#: the caret in consoles can take a while to move on Windows 10 1903 and later.
_caretMovementTimeoutMultiplier = 1.5

def _get_TextInfo(self):
"""Overriding _get_TextInfo and thus the TextInfo property
on NVDAObjects.UIA.UIA
consoleUIATextInfo fixes expand/collapse, implements word movement, and
bounds review to the visible text."""
return consoleUIATextInfo

def _get_caretMovementDetectionUsesEvents(self):
"""Using caret events in consoles sometimes causes the last character of the
prompt to be read when quickly deleting text."""
Expand Down