Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report groupings in browse mode when they have a name. #10425

Closed
wants to merge 10 commits into from

Conversation

LeonarddeR
Copy link
Collaborator

Link to issue number:

Fixes #10095
Fixes #10083
Fixes #9485
fixes #9177
Fixes #5326

Summary of the issue:

Aria role grouping is not conveyed by NVDA. This also applies to other grouping types, like fieldsets and figures.

Description of how this pull request fixes the issue:

Added the ability to report groupingsin browse mode. It can be disabled using the document formatting category of NVDA's settings. Groupings are only reported when they have a label, legend or caption.

Testing performed:

Tested several examples from the issues listed above.

Known issues with pull request:

  1. Edge tends to classify objects as groupings much more often than IA2 based browsers do. Some wider testing in Edge is required to find out whether this is annoying.
  2. Figures are still reported as groupings. We should decide on whether to add a new figure role, map this to graphic or diagram, or leave this as is (grouping).

Change log entry:

@AppVeyorBot
Copy link

PR introduces Flake8 errors 😲

See test results for Failed build of commit 023d5d7abf

@LeonarddeR
Copy link
Collaborator Author

This now also adds the figure role for now, as I remembered I had some code that already did this. Note that this pr touches the same code as in #10424, so probably best to Finnish #10424 first.

@AppVeyorBot
Copy link

PR introduces Flake8 errors 😲

See test results for Failed build of commit 67ea95bd99

@AppVeyorBot
Copy link

PR introduces Flake8 errors 😲

See test results for Failed build of commit ab0cee102b

@LeonarddeR
Copy link
Collaborator Author

Superseded by #10462

@LeonarddeR LeonarddeR closed this Nov 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment