-
-
Notifications
You must be signed in to change notification settings - Fork 660
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Report groupings in browse mode when they have a name. #10425
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR introduces Flake8 errors 😲 See test results for Failed build of commit 023d5d7abf |
PR introduces Flake8 errors 😲 See test results for Failed build of commit 67ea95bd99 |
PR introduces Flake8 errors 😲 See test results for Failed build of commit ab0cee102b |
This was referenced Oct 30, 2019
Superseded by #10462 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #10095
Fixes #10083
Fixes #9485
fixes #9177
Fixes #5326
Summary of the issue:
Aria role grouping is not conveyed by NVDA. This also applies to other grouping types, like fieldsets and figures.
Description of how this pull request fixes the issue:
Added the ability to report groupingsin browse mode. It can be disabled using the document formatting category of NVDA's settings. Groupings are only reported when they have a label, legend or caption.
Testing performed:
Tested several examples from the issues listed above.
Known issues with pull request:
Change log entry:
New features
Changes