UI Automation in Windows Console: Use UIA by default on Windows 10 version 2004 and later #10716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit b00c3f1.
…on Windows 10 2004.
See test results for failed build of commit 828d40f7e8 |
See test results for failed build of commit 1faa8e90b0 |
3 tasks
|
Is it also within the scope of microsoft/terminal#4018 to address other UIA issues, like:
|
|
May be worth reporting the GetVisibleRanges issues if still reproducible. Can you have a look?
…Sent from my iPhone
On Jan 24, 2020, at 01:54, Leonard de Ruijter ***@***.***> wrote:
Is it also within the scope of microsoft/terminal#4018 to address other UIA issues, like:
Many blank lines at the end of the console
Issues with visible ranges calculation we bumped into earlier
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
|
I don't recall the exact issue nor an issue number.
|
See #10559. |
codeofdusk
added a commit
to codeofdusk/nvda
that referenced
this pull request
Feb 13, 2020
|
Superseded by #10784. |
codeofdusk
added a commit
to codeofdusk/nvda
that referenced
this pull request
Apr 1, 2020
michaelDCurran
pushed a commit
that referenced
this pull request
Apr 6, 2020
* Bring over ConsoleUIATextInfo refactoring from #10716. * Add WinTerminalUIA * Style. * Review actions. * microsoft/terminal#4495: support fixed GetVisibleRanges. * KeyboardHandlerBasedTypedCharSupport -> EnhancedTermTypedCharSupport, add _shouldUseToUnicodeEx flag and set False for WinTerminalUIA. * Update doc comments. * Update copyrights. * Review actions. * Factor out bounding into separate method. * Re-introduce KeyboardHandlerBasedTypedCharSupport. * Fix UIA console support for newer Windows Console builds. * Revert copyright header changes. * Revert another no longer necessary copyright header change. * Fix comments. * Update docstring. * Review actions. * Update source/NVDAObjects/behaviors.py Co-Authored-By: Leonard de Ruijter <leonardder@users.noreply.github.com> * Add class docstring. * Optimization: clear character buffers when reporting new lines. This saves us from scanning the old and new lines twice in _calculateNewText (once for diffing and once for finding nonblank indices), and fixes typed word reporting for 21H1 console. This new approach does not resolve #10942. * Update inaccurate information in user guide. Co-authored-by: Leonard de Ruijter <leonardder@users.noreply.github.com>
seanbudd
pushed a commit
that referenced
this pull request
Jun 21, 2022
…(Windows 11 Sun Valley 2) (#10964) Supersedes #9771 and #10716. Closes #1682. Closes #8653. Closes #9867. Closes #11172. Closes #11554. Summary of the issue: Microsoft has significantly improved performance and reliability of UIA console: * microsoft/terminal#4018 is an almost complete rewrite of the UIA code which makes the console's UIA implementation more closely align with the API specification. * microsoft/terminal#10886, microsoft/terminal#10925, and microsoft/terminal#11253 form a robust testing methodology for the UIA implementation, including bug fixes in response to newly added tests based on Word's UIA implementation. * microsoft/terminal#11122 removes the thousands of empty lines at the end of the console buffer, significantly improving performance and stability. Since all console text ranges are now within the text buffer's bounds, it is no longer possible for console to crash due to the manipulation by UIA clients of an out-of-bounds text range. * Countless other accessibility-related PRs too numerous to list here. We should enable UIA support on new Windows Console builds by default for performance improvement and controllable password suppression. Description of how this pull request fixes the issue: This PR: * Exposes all three options for the UIA console feature flag in the UI (replaces the UIA check box with a combo box). * Adds a runtime check to test if `apiLevel >= FORMATTED`, and use UIA in this case when the user preference is auto. This is the case on Windows 11 Sun Valley 2 (SV2) available now in beta and set for release in the second half of 2022.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Roles back #10682 and #10684. Blocked by microsoft/terminal#4018.
Summary of the issue:
microsoft/terminal#4018 provides native word navigation support and fixes to various UIA text range methods. Since the native implementation can now be trusted in more situations, re-enabling UIA in consoles by default on patched Windows releases is strongly worth considering.
Description of how this pull request fixes the issue:
consoleUIATextInfointoconsoleUIATextInfo(a base class and thetextInfoimplementation to use on newer Windows releases) andconsoleUIATextInfoPre2004(containing the older workarounds)._moveandmovemethods, respectively.UIATextInfomovement and comparison methods on Windows 10 2004.Testing performed:
Tested with the build provided in the upstream PR. Further testing and feedback from @LeonarddeR and @michaelDCurran would be highly appreciated.
Known issues with pull request:
WIN10_VERSIONS_TO_BUILDS[2004]is a placeholder value since version 2004 has not yet been released. This build number should be updated for the stable release.Change log entry:
== New Features ==