-
-
Notifications
You must be signed in to change notification settings - Fork 655
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When entering a secure desktop, cancel speech #14135
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feerrenrut
reviewed
Sep 13, 2022
seanbudd
commented
Sep 13, 2022
seanbudd
commented
Sep 14, 2022
feerrenrut
previously approved these changes
Sep 14, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the suggested comment, happy for this to go ahead.
michaelDCurran
previously approved these changes
Sep 14, 2022
See test results for failed build of commit f35d63248c |
feerrenrut
previously approved these changes
Sep 14, 2022
See test results for failed build of commit f35d63248c |
See test results for failed build of commit f35d63248c |
seanbudd
dismissed stale reviews from feerrenrut and michaelDCurran
via
September 15, 2022 02:22
13b8107
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue number:
None
Summary of the issue:
NVDA 2022.2 would cancel speech when handling the foreground event for entering a secure desktop.
The security patch for 2022.2.1 broke how the foreground event was handled, and subsequently #14105 opted to avoid the foreground event entirely.
This results in NVDA not correctly cancelling speech when entering a secure desktop.
Description of user facing changes
Speech is cancelled when entering a secure desktop
Description of development approach
Cancel speech just before enter sleep mode, when
SecureDesktopNVDAObject
handles it's gain focus event.Testing strategy:
Manual testing
Known issues with pull request:
Change log entries:
N/A unreleased bug in 2022.2.3
Code Review Checklist: