Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When entering a secure desktop, cancel speech #14135

Merged
merged 7 commits into from
Sep 15, 2022
Merged

Conversation

seanbudd
Copy link
Member

@seanbudd seanbudd commented Sep 13, 2022

Link to issue number:

None

Summary of the issue:

NVDA 2022.2 would cancel speech when handling the foreground event for entering a secure desktop.

The security patch for 2022.2.1 broke how the foreground event was handled, and subsequently #14105 opted to avoid the foreground event entirely.

This results in NVDA not correctly cancelling speech when entering a secure desktop.

Description of user facing changes

Speech is cancelled when entering a secure desktop

Description of development approach

Cancel speech just before enter sleep mode, when SecureDesktopNVDAObject handles it's gain focus event.

Testing strategy:

Manual testing

Known issues with pull request:

Change log entries:

N/A unreleased bug in 2022.2.3

Code Review Checklist:

  • Pull Request description:
    • description is up to date
    • change log entries
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • API is compatible with existing add-ons.
  • Documentation:
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • Security precautions taken.

@seanbudd seanbudd added this to the 2022.2.3 milestone Sep 13, 2022
@seanbudd seanbudd requested a review from a team as a code owner September 13, 2022 00:41
@seanbudd seanbudd requested review from feerrenrut and removed request for a team September 13, 2022 00:41
@seanbudd seanbudd self-assigned this Sep 13, 2022
feerrenrut
feerrenrut previously approved these changes Sep 14, 2022
Copy link
Contributor

@feerrenrut feerrenrut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the suggested comment, happy for this to go ahead.

michaelDCurran
michaelDCurran previously approved these changes Sep 14, 2022
@AppVeyorBot
Copy link

See test results for failed build of commit f35d63248c

feerrenrut
feerrenrut previously approved these changes Sep 14, 2022
@AppVeyorBot
Copy link

See test results for failed build of commit f35d63248c

@AppVeyorBot
Copy link

See test results for failed build of commit f35d63248c

@seanbudd seanbudd dismissed stale reviews from feerrenrut and michaelDCurran via 13b8107 September 15, 2022 02:22
@seanbudd seanbudd merged commit c53bc97 into rc Sep 15, 2022
@seanbudd seanbudd deleted the cancelSpeechBeforeSleep branch September 15, 2022 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants