Add support for aria-brailleroledescription from ARIA 1.3. #14748
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue number:
partial fix for #11829
Summary of the issue:
ARIA 1.3 adds a aria-brailleroledescription attribute, which allows the web author to specify a string representation for an element's role, specific to Braille.
For example:
A button whos spoken role description will be "planet" but in Braille it will be shown as the abreviated "plnt".
Description of user facing changes
NVDA will honor the aria-brailleroledescription attribute if set by the web author, when presenting web content on a braille display.
Description of development approach
The internal work to support custom braille role text had already been added to NVDAObjects and controlFields to allow for Braille abbreviations for landmarks. this PR:
brailleroledescription
IAccessible2 attribute if availablebrailleroledescription
IAccessible2 attribute to theroleTextBraille
NvDA attribute on controlFields.Testing strategy:
Given the test uri:
In Firefox, Chrome and Edge:
contenteditable="true"
to the paragraph, ensured that the above actions still caused Braille to show "plnt" and not "planet".Known issues with pull request:
None known.
Change log entries:
New features
Changes
Bug fixes
For Developers
Code Review Checklist: