Skip to content

Add @codeofdusk attributions for Python 3.11 upgrade #15609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 12, 2023

Conversation

codeofdusk
Copy link
Contributor

@codeofdusk codeofdusk commented Oct 12, 2023

Link to issue number:

Fix-up of #15513 #15514 .

Description of how this pull request fixes the issue:

Add @codeofdusk attributions for Python 3.11 upgrade

Testing strategy:

N/A

Known issues with pull request:

None known

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

Sorry, something went wrong.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@codeofdusk codeofdusk requested a review from a team as a code owner October 12, 2023 02:38
@codeofdusk codeofdusk requested review from seanbudd and removed request for a team October 12, 2023 02:38
@seanbudd seanbudd closed this Oct 12, 2023
@seanbudd
Copy link
Member

Please do not accredit authors on their behalf. It is up to the author to opt into accreditation

@codeofdusk
Copy link
Contributor Author

This PR includes contributions by me. How do I opt into accreditation?

@seanbudd
Copy link
Member

Apologies, the PR description was misleading:

Many community contributions in 2024.1 are missing attributions.

@seanbudd seanbudd reopened this Oct 12, 2023
@seanbudd seanbudd changed the title Add attributions for 2024.1 (2 of 2) Add @codeofdusk attributions for Python 3.11 upgrade Oct 12, 2023
@seanbudd seanbudd merged commit afa0d92 into nvaccess:py311-min Oct 12, 2023
@nvaccessAuto nvaccessAuto added this to the 2024.1 milestone Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants