Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for text review commands on object name in Visual Studio Code #16248

Merged
merged 11 commits into from
Jun 26, 2024
Merged

Support for text review commands on object name in Visual Studio Code #16248

Show file tree
Hide file tree
Changes from 9 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
8082fac
Support text review commands for Visual Studio Code.
cary-rowen Mar 1, 2024
bfdc425
Update Copyright
cary-rowen Mar 2, 2024
5ca16b7
Update Changes
cary-rowen Mar 2, 2024
de85d47
Merge branch 'master' into VSCodeTextInfo
cary-rowen Mar 5, 2024
425f4ac
Add typing and merge imports
cary-rowen Mar 5, 2024
83b8f9c
Updated changes
cary-rowen Mar 5, 2024
fa8435c
Added comment clarifying that this issue is a specific solution for V…
cary-rowen Mar 5, 2024
ac54b3e
resolve conflicts
cary-rowen Mar 11, 2024
81fb617
Merge branch 'master' into VSCodeTextInfo
cary-rowen Apr 12, 2024
5dd50bd
Merge remote-tracking branch 'origin/master' into VSCodeTextInfo
seanbudd Jun 26, 2024
2029352
update changes
seanbudd Jun 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions source/appModules/code.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,15 @@
# A part of NonVisual Desktop Access (NVDA)
# Copyright (C) 2020 NV Access Limited, Leonard de Ruijter
# Copyright (C) 2020-2024 NV Access Limited, Leonard de Ruijter, Cary-Rowen
# This file is covered by the GNU General Public License.
# See the file COPYING for more details.

""" App module for Visual Studio Code.
"""

import appModuleHandler
import controlTypes
from NVDAObjects.IAccessible.chromium import Document
from NVDAObjects import NVDAObject

from NVDAObjects import NVDAObject, NVDAObjectTextInfo

class VSCodeDocument(Document):
"""The only content in the root document node of Visual Studio code is the application object.
Expand All @@ -24,3 +24,12 @@ class AppModule(appModuleHandler.AppModule):
def chooseNVDAObjectOverlayClasses(self, obj, clsList):
if Document in clsList and obj.IA2Attributes.get("tag") == "#document":
clsList.insert(0, VSCodeDocument)

def event_NVDAObject_init(self, obj: NVDAObject):
# This is a specific fix for Visual Studio Code,
# However, the root cause of the issue is issue #15159.
# Once issue #15159 is fixed,
# The PR #16248 that introduced this code can be immediately reverted.
# (see issue #15159 for full description)
if obj.role != controlTypes.Role.EDITABLETEXT:
obj.TextInfo = NVDAObjectTextInfo
seanbudd marked this conversation as resolved.
Show resolved Hide resolved
1 change: 1 addition & 0 deletions user_docs/en/changes.t2t
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,7 @@ What's New in NVDA
- ``alt+downArrow`` is now mapped to ``dot5+dot6+dot7+space``
-
- Fixed a bug causing NVDA to fail to read the ribbon and options within Geekbench. (#16251, @mzanm)
- Support added for text review commands for an object's name in Visual Studio Code. (#16248, @Cary-Rowen)
- Windows 11 fixes:
- NVDA will once again announce hardware keyboard input suggestions. (#16283, @josephsl)
- In Version 24H2 (2024 Update and Windows Server 2025), mouse and touch interaction can be used in quick settings. (#16348, @josephsl)
Expand Down