Fix Edit.makeTextInfo(caret) when selection is present

[mltony]

Link to issue number:

N/A - please let me know if you want me to create a proper issue first

Summary of the issue:

Suppose some text is selected in NVDA log viewer. Caret can be either at the beginning or at the end of selection, depending on whether we selected text back or forward. Now when calling

focus.makeTextInfo('caret')

I observed that instead of actual caret position, it always returns the beginning of the selection, which is wrong.

Description of user facing changes

N/A as far as I can tell.

Description of development approach

This PR fixes bug in NVDAObjects.window.edit.ITextDocumentTextInfo class.
I query ITextSelection.Flags and check whetehr tomSelStartActive flag is set, and depending on that I collapse either to beginning or to the end depending where the curosr actually is located at the moment.

Testing strategy:

Tested manually in NVDA log viewer. In order to figure out where caret resides I use the following snippet:

t=focus.makeTextInfo('caret')
t.move('character', 1, 'end')
t.text

Known issues with pull request:

N/A

Notes

Just for the record if anyone is interested why I'm proposing this change. I am working on customized word selection script for WordNav add-on and one thing I need is to be able to determine whether caret is currently residing at the beginning or at the end of the selection. It would help if this issue is fixed in the core.

Code Review Checklist:

• Documentation:
  • Change log entry
  • User Documentation
  • Developer / Technical Documentation
  • Context sensitive help for GUI changes
• Testing:
  • Unit tests
  • System (end to end) tests
  • Manual testing
• UX of all users considered:
  • Speech
  • Braille
  • Low Vision
  • Different web browsers
  • Localization in other languages / culture than English
• API is compatible with existing add-ons.
• Security precautions taken.

[LeonarddeR]

Nice catch!

The base branch was changed.

[burmancomp]

I have noticed this behavior change:
When selecting text with shift+down arrow in wordpad atleast in windows 10, review position moves to next line after last selected line (to first unselected line).
This does not happen in notepad or in word 2019.
If I revert this pr review position is unchanged when selecting text also in wordpad.