Report aria-label and aria-description even when parent has no visible children #16471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
is this ready for review? |
seanbudd
reviewed
May 2, 2024
seanbudd
approved these changes
May 2, 2024
seanbudd
added
the
conceptApproved
|
Could you move the changes to the new changes.md for this PR please? |
Moved changelog entry from T2T to Markdown
XLTechie
pushed a commit
to XLTechie/xlnvda
that referenced
this pull request
May 10, 2024
…e children (nvaccess#16471) Fixes nvaccess#14514 Summary of the issue: HTML figure elements with no accessible children (EG, all children set to aria-hidden=true) but with an aria-label or aria-description are not reported by NVDA. Description of user facing changes Elements with no accessible children but which have a label or description are now reported in browse mode. Note this only applies to elements which are still rendered; if all children are set to display: none, for example, NVDA still does not report the parent element. Description of development approach Render a single space in elements with no content but a label or description se
|
I'm afraid this pr has unexpected side effects. Se #16554 |
LeonarddeR
reviewed
May 15, 2024
| @@ -1262,11 +1262,13 @@ VBufStorage_fieldNode_t* GeckoVBufBackend_t::fillVBuf( | |||
| parentNode->isBlock=false; | |||
| } | |||
|
|
|||
| if ((isInteractive || role == ROLE_SYSTEM_SEPARATOR) && parentNode->getLength() == 0) { | |||
| if ((isInteractive || role == ROLE_SYSTEM_SEPARATOR || name || description.has_value()) && parentNode->getLength() == 0) { | |||
There was a problem hiding this comment.
Should name be changed to name.has_value() here?
There was a problem hiding this comment.
Not exactly, as name is a BSTR, not an optional<wstring>. I have checked that it's non-null and non-empty in my updated code though.
5 tasks
seanbudd
pushed a commit
that referenced
this pull request
May 23, 2024
…16585) Fixes #16554 Summary of the issue: #16471 introduced a regression whereby many blank lines were reported in browse mode. Description of user facing changes Extraneous blank lines are no longer reported in browse mode. Description of development approach Updated checks in gecko_ia2.cpp: Check that the length of name is non-zero (SysStringLen returns 0 if the BSTR passed is null) Added check that description's value is not the empty string, as checking that it has a value is necessary but not sufficient.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #14514
Summary of the issue:
HTML
figureelements with no accessible children (EG, all children set toaria-hidden=true) but with anaria-labeloraria-descriptionare not reported by NVDA.Description of user facing changes
Elements with no accessible children but which have a label or description are now reported in browse mode. Note this only applies to elements which are still rendered; if all children are set to
display: none, for example, NVDA still does not report the parent element.Description of development approach
Render a single space in elements with no content but a label or description set.
Testing strategy:
Manually tested in Firefox and Edge, using the example markup provided by the OP.
Known issues with pull request:
N/A
Code Review Checklist: