Run the uninstaller with administrator privileges

[wmhn1872265132]

Link to issue number:

none

Summary of the issue:

NVDA cannot be uninstalled correctly by directly running "%ProgramFiles(x86)%\NVDA\uninstall.exe". You must run it as an administrator to uninstall it correctly.

Description of user facing changes

You can directly run "%ProgramFiles(x86)%\NVDA\uninstall.exe" to uninstall NVDA

Description of development approach

Change RequestExecutionLevel to admin

Testing strategy:

Manually run "%ProgramFiles(x86)%\NVDA\uninstall.exe", the uninstaller should correctly apply for administrator rights and uninstall NVDA

Known issues with pull request:

The portable version of NVDA's uninstall.exe will also apply for administrator rights when running.

Code Review Checklist:

• Documentation:
  • Change log entry
  • User Documentation
  • Developer / Technical Documentation
  • Context sensitive help for GUI changes
• Testing:
  • Unit tests
  • System (end to end) tests
  • Manual testing
• UX of all users considered:
  • Speech
  • Braille
  • Low Vision
  • Different web browsers
  • Localization in other languages / culture than English
• API is compatible with existing add-ons.
• Security precautions taken.

[seanbudd]

The portable version of NVDA's uninstall.exe will also apply for administrator rights when running.

I think that's okay. I assume that tool is used to uninstall NVDA from a computer, not delete the portable copy. A portable copy cannot be installed or uninstalled

[seanbudd]

I'm reverting this PR as it makes admin permissions required to generate the uninstaller. I don't believe this is setup correctly.
The installer doesn't require this and uses RequestExecutionLevel user.

Please file an issue first describing the problem you are facing, as generally the uninstaller works for me and requests admin level.

[michaelDCurran]

It seems that When running the uninstaller from control panel / programs and features, or Windows Settings -> Apps -> installed apps: Windows automatically elevates the uninstaller. I.e. I get a UAC screen each time.
However, when running uninstall.exe directly from c:\program files (x86)\nvda, for instance using File Explorer, the uninstaller ls launched with no UAC elevation.
I would not think it is a very likely / supported pattern to run it directly. Generally people should use the installed apps / programs and features UI.

[seanbudd]

I agree, I think the typical pattern here for consumers is to run commands from an administrator terminal when its needed.

[wmhn1872265132]

But the uninstall icon in C:\ProgramData\Microsoft\Windows\Start Menu\Programs\NVDA cannot be used. I think either keep this PR or fix this problem through other solutions, or delete the uninstall icon here.

[michaelDCurran]

Good point. Yes, we should either remove that shortcut, or change it to use the shell to request elevation. Message ID: ***@***.***>

[wmhn1872265132]

Also, I really don’t think running the uninstall program directly should be unsupported, unless the program is invisible to the user, otherwise there should be no reason to prevent the user from doing this.

[seanbudd]

Please open a new issue for the shortcut bug