Windows 11 clipboard history: redirect NVDA focus if Windows Input Experience window receives focus when clipboard history window closes #16534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n focus event appears when closing clipboard history. Re nvaccess#16347. When closing Wndows 11 clipboard history, Windows Input Experience window receives focus (as recorded by NVDA). This causes keyboard commands not appear to work when in fact clipboard history window is offscreen. Thankfully, a reference to the actual system focus control can be obtained via obj.objectWithFocus() function, therefore move NVDA's 'focus' to system focus.
seanbudd
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Closes #16347
Summary of the issue:
In Windows 11, Windows Input Experience window receives focus when clipboard history closes.
Description of user facing changes
NVDA will no longer appear to get stuck when closing Windows 11 clipboard history.
Description of development approach
In emoji panel app module, added again focus event handler that will check if Windows Input Experience window receives focus in Windows 11, and if yes and if no events are pending, will queue gain focus on system focus control (obj.objectWithFocus()).
Testing strategy:
Manual testing: in Windows 11, open clipboard history, then press Escape to close it.
Known issues with pull request:
This is raised when 32-bit AccEvent is run but not while using 64-bit AccEvent, so this issue should be revisited as part of #16304. For now, the PR works.
Code Review Checklist: