Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix up for numbered headings for Western Arabic #16575

Merged
merged 2 commits into from
May 20, 2024
Merged

Conversation

seanbudd
Copy link
Member

@seanbudd seanbudd commented May 20, 2024

Link to issue number:

Fixup of #16425
Discussed here: https://groups.io/g/nvda-translations/message/3819

Summary of the issue:

In 2023.2, the user guide heading numbering for the Arabic translation switched to using Western Arabic numbering.
2024.1 mistakenly switched this back to Eastern Arabic numbering.
In #16425, the headers in the table of contents were fixed for Western Arabic, but not in the body.

Description of user facing changes

Restore Western Arabic numbering style for headings in the body of the document

Description of development approach

Updated CSS to reflect Western Arabic numbering style i.e. .1.2.3, .1.2.4

Testing strategy:

Compared:

Known issues with pull request:

None

@seanbudd seanbudd changed the title Update translations from Crowdin Fix up for numbered headings for Western Arabic May 20, 2024
@seanbudd seanbudd marked this pull request as ready for review May 20, 2024 06:15
@seanbudd seanbudd requested a review from a team as a code owner May 20, 2024 06:15
@seanbudd seanbudd requested review from SaschaCowley and removed request for a team May 20, 2024 06:15
@seanbudd seanbudd added this to the 2024.2 milestone May 20, 2024
@seanbudd seanbudd merged commit 7943274 into beta May 20, 2024
3 checks passed
@seanbudd seanbudd deleted the fixupArabicHeaders branch May 20, 2024 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants