Do not erase a modified line when moving in the Python console history #16654
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Closes #16653
Summary of the issue:
Unexecuted commands are lost when moving in the python console history.
Description of user facing changes
If a command has been written or modified in the console but not executed, it will not be lost. In case the modified command is not the last in the history, the original history item will not be overriden (as it was before #15794), but it will be copied in last position in the history so that it can be edited.
Description of development approach
Tracked text modification with an appropriate event to react accordingly.
Testing strategy:
Manual tests.
Known issues with pull request:
As soon as you modify an item in the history, you lose your position in the history and turn back to last item.
Though it is preferred to avoid overwriting items in the history.
Code Review Checklist: