Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not erase a modified line when moving in the Python console history #16654

Merged
merged 2 commits into from
Jun 6, 2024

Conversation

CyrilleB79
Copy link
Collaborator

Link to issue number:

Closes #16653

Summary of the issue:

Unexecuted commands are lost when moving in the python console history.

Description of user facing changes

If a command has been written or modified in the console but not executed, it will not be lost. In case the modified command is not the last in the history, the original history item will not be overriden (as it was before #15794), but it will be copied in last position in the history so that it can be edited.

Description of development approach

Tracked text modification with an appropriate event to react accordingly.

Testing strategy:

Manual tests.

Known issues with pull request:

As soon as you modify an item in the history, you lose your position in the history and turn back to last item.
Though it is preferred to avoid overwriting items in the history.

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

@CyrilleB79
Copy link
Collaborator Author

@cary-rowen, could you test this PR when the build is ready?

@cary-rowen
Copy link
Contributor

Thanks @CyrilleB79
Yes, this works for me.

@CyrilleB79 CyrilleB79 marked this pull request as ready for review June 5, 2024 17:51
@CyrilleB79 CyrilleB79 requested a review from a team as a code owner June 5, 2024 17:51
@CyrilleB79 CyrilleB79 requested a review from michaelDCurran June 5, 2024 17:51
source/pythonConsole.py Outdated Show resolved Hide resolved
@seanbudd seanbudd merged commit ebee59b into nvaccess:master Jun 6, 2024
1 check was pending
@CyrilleB79 CyrilleB79 deleted the consoleHistory branch June 7, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NVDA Python console loses unexecuted command
3 participants