Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use UIA caret events in Windows Terminal #16873

Merged
merged 3 commits into from
Jul 18, 2024
+7 −3
Merged

Use UIA caret events in Windows Terminal #16873

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cf0ef15
Enable caret events in Windows Terminal
codeofdusk Jul 4, 2024
b4bf5ac
Update what's new
codeofdusk Jul 17, 2024
d6e7e44
Update source/NVDAObjects/UIA/winConsoleUIA.py
seanbudd Jul 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions source/NVDAObjects/UIA/winConsoleUIA.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -450,6 +450,10 @@ def event_UIA_notification(self, **kwargs):
"Block notification events when diffing to prevent double reporting."
log.debugWarning(f"Notification event blocked to avoid double-report: {kwargs}")

def _get_caretMovementDetectionUsesEvents(self) -> bool:
"Windows Terminal has a good implementation of caret move detection."
return True


class _NotificationsBasedWinTerminalUIA(UIA):
"""
Expand Down
6 changes: 3 additions & 3 deletions user_docs/en/changes.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,12 +12,12 @@

### Bug Fixes

* NVDA once again relies on UIA events for caret movement in XAML and WPF text controls, rather than only on manual querying of the caret position. (#16817, @LeonarddeR)
* The Seika Notetaker driver now correctly generates braille input for space, backspace and dots with space/backspace gestures. (#16642, @school510587)
* In on-demand speech mode, NVDA does not talk anymore when a message is opened in Outlook, when a new page is loaded in a browser or during the slideshow in PowerPoint. (#16825, @CyrilleB79)
* NVDA once again relies on events for caret movement in several cases, rather than only on manual querying of the caret position.
* UIA for XAML and WPF text controls. (#16817, @LeonarddeR)
* IAccessible2 for browsers such as Firefox and Chromium based browsers. (#11545, #16815, @LeonarddeR)
* UIA in Windows Terminal. (#16873, @codeofdusk)
codeofdusk marked this conversation as resolved.
Show resolved Hide resolved
* The Seika Notetaker driver now correctly generates braille input for space, backspace and dots with space/backspace gestures. (#16642, @school510587)
* In on-demand speech mode, NVDA does not talk anymore when a message is opened in Outlook, when a new page is loaded in a browser or during the slideshow in PowerPoint. (#16825, @CyrilleB79)
codeofdusk marked this conversation as resolved.
Show resolved Hide resolved


### Changes for Developers
Expand Down