Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge beta to master #17185

Merged
merged 4 commits into from
Sep 17, 2024
Merged

Merge beta to master #17185

merged 4 commits into from
Sep 17, 2024

Conversation

SaschaCowley
Copy link
Member

@SaschaCowley SaschaCowley commented Sep 17, 2024 •
edited by coderabbitai bot
Loading

Summary by CodeRabbit

  • New Features

    • Added translations for various braille commands and user interface elements across multiple languages, enhancing accessibility for users in their native languages.

  • Bug Fixes

    • Corrected and completed translations for previously untranslated terms and phrases in various localization files, improving clarity and usability.

  • Documentation

    • Updated metadata timestamps in localization files to reflect recent changes and revisions.

CyrilleB79 and others added 4 commits September 12, 2024 16:51
@CyrilleB79
Fix documentation formatting (#17121)
7d3b33e 
Commands Quick Reference includes text that was not intended to be included, due to missing closing tag <!-- KC:endInclude -->
Description of user facing changes
The Commands Quick Reference will no longer include text unrelated to shortcut keys.
Description of development approach
Added the closing tag in the User Guide.
@actions-user
Update user_docs/en/userGuide.xliff
7b67402
@SaschaCowley
Update translations from Crowdin (#17178)
e5210bb
@SaschaCowley
Restored erroneously modified English xliffs (#17180)
9fe4541
@SaschaCowley SaschaCowley requested review from a team as code owners September 17, 2024 07:30
@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 17, 2024 •
edited
Loading

Caution

Review failed

The pull request is closed.

Walkthrough

The changes involve updates to the metadata in various localization files for the NVDA project, specifically modifying the timestamps for the POT-Creation-Date and PO-Revision-Date fields. These updates reflect recent revisions and do not alter the functionality or logic of the code. Additionally, several localization files have been enhanced with new translations for various terms and phrases, improving the completeness of the localization.

Changes

Files Change Summary
source/locale/*.po (except ca.po, de.po, es.po, pt_BR.po, kmr.po, mn.po, it.po, fr.po, es_CO.po, nl.po, nb_NO.po, ro.po, ru.po, sk.po, pl.po, he.po, hi.po, fa.po, da.po, hu.po, cs.po, bg.po, bn.po, an.po, ar.po, ckb.po, el.po, ga.po, is.po, ja.po, ka.po, kn.po, ko.po, ky.po, lt.po, mk.po, my.po, ne.po, nn_NO.po, so.po, sq.po, sl.po, hr.po, id.po, fi.po, af_ZA.po, am.po, de_CH.po) Updated timestamps for POT-Creation-Date and PO-Revision-Date.
source/locale/ca/LC_MESSAGES/nvda.po Added translations for Japanese input modes and braille display settings.
source/locale/de/LC_MESSAGES/nvda.po Added translations for various braille settings and commands, enhancing the completeness of the localization.
source/locale/es/LC_MESSAGES/nvda.po Added translations for braille symbols and user interface messages, improving clarity and usability.
source/locale/es_CO/LC_MESSAGES/nvda.po Added and modified translations for various terms and phrases, enhancing the clarity of the localization.
source/locale/kmr/LC_MESSAGES/nvda.po Added translations for braille commands, improving accessibility for Kurmanji-speaking users.
source/locale/mn/LC_MESSAGES/nvda.po Added translations for navigation commands in browse mode, enhancing user experience for Mongolian-speaking users.
source/locale/pt_BR/LC_MESSAGES/nvda.po Added a translation for a previously untranslated message related to Excel functionality.
source/locale/it/LC_MESSAGES/nvda.po Added translations for braille symbols and commands, enhancing accessibility for Italian-speaking users.
source/locale/fr/LC_MESSAGES/nvda.po Updated translations for specific strings related to braille display functionality.
source/locale/ru/LC_MESSAGES/nvda.po Modified translations for "native selection mode" and added pluralization for suggestion messages, improving clarity and consistency.

Possibly related PRs

  • Update translations #17137: The changes in this PR involve updates to the metadata in the nvda.po file, specifically the timestamps, which align with the changes made in the main PR regarding the POT-Creation-Date and PO-Revision-Date. Both PRs reflect similar administrative updates to the same localization files.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    -- I pushed a fix in commit <commit_id>, please review it.
    -- Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    -- @coderabbitai generate unit testing code for this file.
    -- @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    -- @coderabbitai generate interesting stats about this repository and render them as a table.
    -- @coderabbitai read src/utils.ts and generate unit testing code.
    -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.
Early access features: enabled

We are currently testing the following features in early access:

  • OpenAI o1 for code reviews: OpenAI's new o1 model is being tested for generating code suggestions in code reviews.

Note:

  • You can enable or disable early access features from the CodeRabbit UI or by updating the CodeRabbit configuration file.

@SaschaCowley SaschaCowley merged commit 7bf9116 into master Sep 17, 2024
6 of 7 checks passed
@github-actions github-actions bot added this to the 2025.1 milestone Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Qchristensen Qchristensen Awaiting requested review from Qchristensen Qchristensen is a code owner automatically assigned from nvaccess/userdocs

@seanbudd seanbudd Awaiting requested review from seanbudd seanbudd is a code owner automatically assigned from nvaccess/developers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2025.1
Development

Successfully merging this pull request may close these issues.
3 participants
@SaschaCowley @CyrilleB79 @actions-user