Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed a message in input help mode for speak command keys command #17472

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

Adriani90
Copy link
Collaborator

Link to issue number:

fixes #17470

Summary of the issue:

Small inconsistency between user guide and input help mode

Description of user facing changes

same message which is spoken when toggling the setting, and can also be found in the user guide.

Description of development approach

Changed the coresponding message in globalCommands.py

Testing strategy:

Tested that it fires correctly when input help is on and nvda+4 is pressed.

Known issues with pull request:

None

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

@coderabbitai summary

@Adriani90 Adriani90 requested a review from a team as a code owner December 2, 2024 21:51
@seanbudd seanbudd merged commit 1fd469a into nvaccess:master Dec 2, 2024
5 checks passed
@github-actions github-actions bot added this to the 2025.1 milestone Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change the string related to typing command keys
2 participants