Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make continuous reading work when using SAPI5 voices without bookmark support #17523

Merged
merged 12 commits into from
Jan 12, 2025
Merged

Make continuous reading work when using SAPI5 voices without bookmark support #17523

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
8c2aedf
Make continuous reading work when using SAPI5 voices without bookmark…
gexgd0419 Dec 14, 2024
b4d8f04
Merge branch 'nvaccess:master' into fix-sapi5-continuous-reading
gexgd0419 Dec 16, 2024
dbd087c
Add changelog entry
gexgd0419 Dec 16, 2024
d963096
Fix
gexgd0419 Dec 16, 2024
d38197b
Fix SAPI4 continuous reading
gexgd0419 Dec 17, 2024
0dec8e7
Merge branch 'master' into fix-sapi5-continuous-reading
gexgd0419 Jan 2, 2025
862a282
Merge branch 'master' into fix-sapi5-continuous-reading
gexgd0419 Jan 9, 2025
65387a8
Add type hints
gexgd0419 Jan 9, 2025
23fae4e
Merge branch 'master' into fix-sapi5-continuous-reading
gexgd0419 Jan 10, 2025
ee5d505
Apply suggestion
gexgd0419 Jan 10, 2025
33fa2d0
Add API breaking change entry
gexgd0419 Jan 10, 2025
bf00689
Update user_docs/en/changes.md
seanbudd Jan 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions source/synthDrivers/sapi4.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ class SynthDriverBufSink(COMObject):
def __init__(self, synthRef: weakref.ReferenceType):
self.synthRef = synthRef
self._allowDelete = True
super(SynthDriverBufSink, self).__init__()
super().__init__()

def ITTSBufNotifySink_BookMark(self, this, qTimeStamp: int, dwMarkNum: int):
synth = self.synthRef()
Expand Down Expand Up @@ -88,7 +88,7 @@ class SynthDriverSink(COMObject):

def __init__(self, synthRef: weakref.ReferenceType):
self.synthRef = synthRef
super(SynthDriverSink, self).__init__()
super().__init__()

def ITTSNotifySinkW_AudioStart(self, this, qTimeStamp: int):
synth = self.synthRef()
Expand Down
1 change: 1 addition & 0 deletions user_docs/en/changes.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,6 +174,7 @@ Instead, a `callback` property has been added, which returns a function that per
* Because SAPI5 voices now use `nvwave.WavePlayer` to output audio: (#17592, @gexgd0419)
* `synthDrivers.sapi5.SPAudioState` has been removed.
* `synthDrivers.sapi5.SynthDriver.ttsAudioStream` has been removed.
* `synthDrivers.sapi5.SapiSink.onIndexReached` now expects two arguments: stream number and index. (#17523, @gexgd0419)
seanbudd marked this conversation as resolved.
Show resolved Hide resolved

#### Deprecations

Expand Down