Skip to content

Commit

Permalink
sql/logictest: add logictest for all expected 1PC txn statements
Browse files Browse the repository at this point in the history
First commit from cockroachdb#41324.

We expect a selection of simple single-statement mutations to hit the
"1-phase commit" transaction fast-path. cockroachdb#41320 demonstrated how critical
this is, as regressions here can cause major (> 50%) performance hits to
benchmarks and user workloads. This commit adds a logic test to validate
that these statements continue to hit this fast-path.

Release justification: Testing only.

Release note: None
  • Loading branch information
nvanbenschoten committed Oct 8, 2019
1 parent 7f8687b commit a0dde23
Show file tree
Hide file tree
Showing 2 changed files with 354 additions and 18 deletions.
1 change: 1 addition & 0 deletions pkg/sql/delete_range.go
Original file line number Diff line number Diff line change
Expand Up @@ -191,6 +191,7 @@ func (d *deleteRangeNode) startExec(params runParams) error {
}
}
} else {
log.Event(ctx, "autocommit enabled")
// With autocommit, we're going to run the deleteRange in a single batch
// without a limit, since limits and deleteRange aren't compatible with 1pc
// transactions / autocommit. This isn't inherently safe, because without a
Expand Down
Loading

0 comments on commit a0dde23

Please sign in to comment.