Skip to content
This repository has been archived by the owner on Nov 5, 2024. It is now read-only.

fix build when git information is not available #303

Merged
merged 1 commit into from
Sep 21, 2023
Merged

fix build when git information is not available #303

merged 1 commit into from
Sep 21, 2023

Conversation

figsoda
Copy link
Contributor

@figsoda figsoda commented Sep 19, 2023

No description provided.

@Myriad-Dreamin
Copy link
Collaborator

Myriad-Dreamin commented Sep 19, 2023

It looks strange for me to retrieve git revision hash manually with having an existing well-maintained crate vergen, though laurmagedje said he don't like a things like git2rs which will introduce many build dependencies. One could use embedded git by git2 feature or git command line interface by gitcl feature.

@KillTheMule
Copy link
Contributor

You can see at #292 that I tried to use one lib for this, but it triggered security checks, so I simply inlined the needed functionality. I'd still say that not using a lib here is beneficial b/c of compile time dependencies piling up, but that's certainly @nvarner 's call to make.

@nvarner
Copy link
Owner

nvarner commented Sep 21, 2023

Since it's not a major piece of functionality, and the official releases are built in an environment with git, I think this is a better solution than taking on a big dependency. It's a bit hacky, but it works. I'll try to get this merged soon.

@nvarner nvarner merged commit 1eb2823 into nvarner:master Sep 21, 2023
@figsoda figsoda deleted the git branch September 21, 2023 21:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants