Skip to content

chore: add pana max score validation task #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 5, 2025

Conversation

Arieldelossantos
Copy link
Contributor

@Arieldelossantos Arieldelossantos commented Apr 28, 2025

GitHub Issue: #

Proposed Changes

  • Bug fix
  • Feature
  • Code style update (formatting)
  • Refactoring (no functional changes, no api changes)
  • Build or CI related changes
  • Documentation content changes
  • Other, please describe:

Description

Added a validation to ensure the Pana score meets the required threshold of 160. This step reads the pana-analysis.md file, extracts the score, and checks if it meets the threshold. If the score is below 160, it identifies areas with reduced scores and fails the build. This ensures code quality and compliance with Pana analysis standards.

Impact on version

  • Major
    • The template structure was changed.
  • Minor
    • New functionalities were added.
  • Patch
    • A bug in behavior was fixed.
    • Documentation was changed.

PR Checklist

Always applicable

No matter your changes, these checks always apply.

  • Your conventional commits are aligned with the Impact on version section.
  • Updated CHANGELOG.md.
    • Use the latest Major.Minor.X header if you do a Patch change.
    • Create a new Major.Minor.X header if you do a Minor or Major change.
    • If you create a new header, it aligns with the Impact on version section and matches what is generated in the build pipeline.
  • Documentation files were updated according with the changes.
    • Update README.md and src/cli/CLI.md if you made changes to templating.
    • Update AzurePipelines.md and src/app/README.md if you made changes to pipelines.
    • Update Diagnostics.md if you made changes to diagnostic tools.
    • Update Architecture.md and its diagrams if you made architecture decisions or if you introduced new recipes.
    • ...and so forth: Make sure you update the documentation files associated to the recipes you changed. Review the topics by looking at the content of the doc/ folder.
  • Images about the template are referenced from the wiki and added as images in this git.
  • TODO comments are hints for next steps for users of the template and not planned work.

Contextual

Based on your changes these checks may not apply.

  • Automated tests for the changes have been added/updated.
  • Tested on all relevant platforms

Other information

Internal Issue (If applicable):

Sorry, something went wrong.

@Arieldelossantos Arieldelossantos self-assigned this Apr 28, 2025
@Arieldelossantos Arieldelossantos force-pushed the dev/arde/calculate-dev-score-validation branch 2 times, most recently from 5d7cf83 to a7fc775 Compare April 28, 2025 13:32
@Arieldelossantos Arieldelossantos force-pushed the dev/arde/calculate-dev-score-validation branch from a7fc775 to 4e7a2bc Compare May 5, 2025 15:33
@Arieldelossantos Arieldelossantos force-pushed the dev/arde/calculate-dev-score-validation branch from 4e7a2bc to 9b0e66e Compare May 5, 2025 16:32
@Arieldelossantos Arieldelossantos changed the title ci: add pana max score validation task chore: add pana max score validation task May 5, 2025
@Arieldelossantos Arieldelossantos merged commit 3ecb4f9 into main May 5, 2025
17 checks passed
@Arieldelossantos Arieldelossantos deleted the dev/arde/calculate-dev-score-validation branch May 5, 2025 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants