Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate externalCss #132

Merged
merged 16 commits into from
Jun 11, 2022
Merged

Deprecate externalCss #132

merged 16 commits into from
Jun 11, 2022

Conversation

nvh95
Copy link
Owner

@nvh95 nvh95 commented May 31, 2022

Related issue

Features

  • Deprecate externalCss
  • Add a warning when users try to use externalCss
  • Add a blog post to announce about the deprecation
  • Update docs

Chores

  • Update examples not to use externalCss

TLDR

// src/setupTests.js
-jestPreviewConfigure({
-  externalCss: ['src/global.css', 'src/assets/_scss/global-style.scss'],
-});
+import './global.css';
+import './assets/_scss/global-style.scss';

@netlify
Copy link

netlify bot commented May 31, 2022

Deploy Preview for jest-preview-library ready!

Name Link
🔨 Latest commit 4bcfec7
🔍 Latest deploy log https://app.netlify.com/sites/jest-preview-library/deploys/62a4ccffd43b90000954950e
😎 Deploy Preview https://deploy-preview-132--jest-preview-library.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@nvh95 nvh95 linked an issue May 31, 2022 that may be closed by this pull request
@nvh95 nvh95 marked this pull request as draft June 4, 2022 03:38
@nvh95 nvh95 force-pushed the deprecate-externalCss branch from 553a525 to e92ee54 Compare June 4, 2022 10:10
@nvh95 nvh95 force-pushed the deprecate-externalCss branch from 8ca69d9 to c17e250 Compare June 11, 2022 08:14
@nvh95 nvh95 marked this pull request as ready for review June 11, 2022 08:51
@nvh95 nvh95 requested review from ntt261298 and sonngdev June 11, 2022 08:56
@nvh95 nvh95 merged commit 010732e into main Jun 11, 2022
@nvh95 nvh95 deleted the deprecate-externalCss branch June 11, 2022 17:28
@nvh95 nvh95 added the future work needed Merged PR or Closed Issue but need to visit in the future label Jul 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
future work needed Merged PR or Closed Issue but need to visit in the future
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Depreacate externalCss option in jestPreviewConfigure
2 participants