Fix issue not reload on Linux by always read html from index.html
#200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for jest-preview-library ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Closed
nvh95
changed the title
index.html
nvh95
approved these changes
Jul 16, 2022
| </html>`); | ||
| } | ||
| let indexHtml = fs.readFileSync(INDEX_PATH, 'utf8'); | ||
| let indexHtml = fs.readFileSync(INDEX_PATH, 'utf-8'); |
There was a problem hiding this comment.
TIL that we can use utf8 and utf-8 interchangeably.
Reference: https://stackoverflow.com/a/14551669/3422559
This was referenced Jul 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary/ Motivation (TLDR;)
Related issues
Fixes
server.listencallbackindex.htmlto make sure it's always existedapp.use('/')), instead, write to disk at 2.We also tried another approach here (generate a new file name for index.html each time the server starts), we can keep this as a reference #199